From: Carlos Maiolino <cmaiolino@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org, okozina@redhat.com
Subject: Re: [RFC PATCH] iomap: Enable alignment check for iomap DIO in holes
Date: Mon, 8 Oct 2018 09:24:33 +0200 [thread overview]
Message-ID: <20181008072433.ld5kxo4yutfb5tpk@odin.usersys.redhat.com> (raw)
In-Reply-To: <20181006095951.GA6047@lst.de>
On Sat, Oct 06, 2018 at 11:59:51AM +0200, Christoph Hellwig wrote:
> On Fri, Oct 05, 2018 at 03:03:16PM +0200, Carlos Maiolino wrote:
> > Commit 09230435dffdb13de507e5e40b524b0069fc5c7b refactor iomap_dio_actor
> > into two different helpers for bio based IO and hole IO, although, the
> > latter doesn't check for IO alignment anymore.
> >
> > Move the DIO alignment check up into the caller, so all iomap DIO has
> > alignment checked.
>
> Why? The only reason to check alignmnet for actual I/O is because we
> have to. There is no requirement to align holes.
>
> > Christoph, I tagged this patch as RFC, because I couldn't really identify if you
> > intentionally dropped the alignment check for holes and inline actors, if you
> > didn't drop the alignment check intentionally, please consider it as a normal
> > patch.
>
> The primary intent was to simplify the code and not enforce alignment
> for inline data support.
Ok, thanks, so please disregard this patch.
Cheers.
--
Carlos
prev parent reply other threads:[~2018-10-08 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 13:03 [RFC PATCH] iomap: Enable alignment check for iomap DIO in holes Carlos Maiolino
2018-10-06 9:59 ` Christoph Hellwig
2018-10-08 7:24 ` Carlos Maiolino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008072433.ld5kxo4yutfb5tpk@odin.usersys.redhat.com \
--to=cmaiolino@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=okozina@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).