From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 8 Oct 2018 15:23:27 +0200 From: Greg KH To: Miklos Szeredi Cc: Amir Goldstein , Al Viro , linux-fsdevel , overlayfs , stable Subject: Re: [PATCH 03/16] vfs: don't evict uninitialized inode Message-ID: <20181008132327.GD20703@kroah.com> References: <20180729220317.GB30522@ZenIV.linux.org.uk> <20180729220453.13431-1-viro@ZenIV.linux.org.uk> <20180729220453.13431-3-viro@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Mon, Oct 08, 2018 at 08:41:13AM +0200, Miklos Szeredi wrote: > On Fri, Aug 24, 2018 at 8:47 AM, Amir Goldstein wrote: > >> Miklos, > >> > >> Seeing that it wasn't fixed in 4.18.. > >> > >> > I've nothing against applying "new primitive: discard_new_inode() now > >> > + this patch, but if it is deemed too risky at this point, we could > >> > just revert the buggy commit 80ea09a002bf ("vfs: factor out > >> > inode_insert5()") and its dependencies. > >> > > >> > >> Should we propose for stable the upstream commits: > >> e950564b97fd vfs: don't evict uninitialized inode > >> c2b6d621c4ff new primitive: discard_new_inode() > >> > >> Or should we go with the independent v1 patch: > >> https://patchwork.kernel.org/patch/10511969/ > >> > > > > Greg, > > > > To fix a 4.18 overlayfs regression please apply the following > > 3 upstream commits (in apply order): > > > > c2b6d621c4ff new primitive: discard_new_inode() > > e950564b97fd vfs: don't evict uninitialized inode > > 6faf05c2b2b4 ovl: set I_CREATING on inode being created > > Is this fixed in 4.18.z yet? Not yet, sorry, will try to get to that today... greg k-h