From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: david@fromorbit.com, sandeen@redhat.com,
linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
Amir Goldstein <amir73il@gmail.com>,
linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH 07/25] vfs: combine the clone and dedupe into a single remap_file_range
Date: Mon, 15 Oct 2018 09:42:20 -0700 [thread overview]
Message-ID: <20181015164220.GL28243@magnolia> (raw)
In-Reply-To: <20181014171927.GD30673@infradead.org>
On Sun, Oct 14, 2018 at 10:19:27AM -0700, Christoph Hellwig wrote:
> > unsigned (*mmap_capabilities)(struct file *);
> > #endif
> > ssize_t (*copy_file_range)(struct file *, loff_t, struct file *, loff_t, size_t, unsigned int);
> > - int (*clone_file_range)(struct file *, loff_t, struct file *, loff_t, u64);
> > - int (*dedupe_file_range)(struct file *, loff_t, struct file *, loff_t, u64);
> > + int (*remap_file_range)(struct file *file_in, loff_t pos_in,
> > + struct file *file_out, loff_t pos_out,
> > + u64 len, unsigned int remap_flags);
>
> None of the other methods in this file name their parameters. While
> I generally don't like people leaving them out, in the end consistency
> is even more important.
>
> > +int btrfs_remap_file_range(struct file *src_file, loff_t off,
> > + struct file *dst_file, loff_t destoff, u64 len,
> > + unsigned int remap_flags)
> > {
> > + if (!remap_check_flags(remap_flags, RFR_SAME_DATA))
> > + return -EINVAL;
> > +
> > + if (remap_flags & RFR_SAME_DATA) {
>
> So at least for btrfs there seems to be no shared code at all below
> the function calls. This kinda speaks against the argument that
> they fundamentally are the same..
They /do/ share/ code -- eventually both btrfs_extent_same and
btrfs_clone_files call btrfs_clone. xfs and ocfs2 call the same paths
internally too; it's only the vfs helpers that have the extra page cache
comparisons if it's a dedup operation.
> > +/*
> > + * These flags control the behavior of the remap_file_range function pointer.
> > + *
> > + * RFR_SAME_DATA: only remap if contents identical (i.e. deduplicate)
> > + */
> > +#define RFR_SAME_DATA (1 << 0)
> > +
> > +#define RFR_VALID_FLAGS (RFR_SAME_DATA)
>
> RFR? Why not REMAP_FILE_* Also why not the well understood
> REMAP_FILE_DEDUP instead of the odd SAME_DATA?
Sure. I had begin to dislike typing RFR anyway.
> > +
> > +/*
> > + * Filesystem remapping implementations should call this helper on their
> > + * remap flags to filter out flags that the implementation doesn't support.
> > + *
> > + * Returns true if the flags are ok, false otherwise.
> > + */
> > +static inline bool remap_check_flags(unsigned int remap_flags,
> > + unsigned int supported_flags)
> > +{
> > + return (remap_flags & ~(supported_flags & RFR_VALID_FLAGS)) == 0;
> > +}
>
> Any reason to even bother with a helper for this? ->fallocate
> seems to be doing fine without the helper, and the resulting code
> seems a lot easier to understand to me.
(Will respond to these at the current end of the flags thread.)
> > @@ -1759,10 +1779,9 @@ struct file_operations {
> > #endif
> > ssize_t (*copy_file_range)(struct file *, loff_t, struct file *,
> > loff_t, size_t, unsigned int);
> > - int (*clone_file_range)(struct file *, loff_t, struct file *, loff_t,
> > - u64);
> > - int (*dedupe_file_range)(struct file *, loff_t, struct file *, loff_t,
> > - u64);
> > + int (*remap_file_range)(struct file *file_in, loff_t pos_in,
> > + struct file *file_out, loff_t pos_out,
> > + u64 len, unsigned int remap_flags);
>
> Same comment here. Didn't we have some nice doc tools to avoid this
> duplication? :)
We do, but vfs.txt hasn't been ported to any of that.
--D
next prev parent reply other threads:[~2018-10-15 16:42 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 0:05 [PATCH v4 00/25] fs: fixes for serious clone/dedupe problems Darrick J. Wong
2018-10-13 0:05 ` [PATCH 01/25] xfs: add a per-xfs trace_printk macro Darrick J. Wong
2018-10-13 0:05 ` [PATCH 02/25] vfs: vfs_clone_file_prep_inodes should return EINVAL for a clone from beyond EOF Darrick J. Wong
2018-10-13 0:06 ` [PATCH 03/25] vfs: check file ranges before cloning files Darrick J. Wong
2018-10-13 0:06 ` [PATCH 04/25] vfs: strengthen checking of file range inputs to generic_remap_checks Darrick J. Wong
2018-10-13 0:06 ` [PATCH 05/25] vfs: avoid problematic remapping requests into partial EOF block Darrick J. Wong
2018-10-14 17:11 ` Christoph Hellwig
2018-10-13 0:06 ` [PATCH 06/25] vfs: skip zero-length dedupe requests Darrick J. Wong
2018-10-13 0:06 ` [PATCH 07/25] vfs: combine the clone and dedupe into a single remap_file_range Darrick J. Wong
2018-10-14 17:19 ` Christoph Hellwig
2018-10-15 6:04 ` Amir Goldstein
2018-10-15 12:47 ` Christoph Hellwig
2018-10-15 12:54 ` Amir Goldstein
2018-10-15 17:13 ` Darrick J. Wong
2018-10-15 18:32 ` Christoph Hellwig
2018-10-15 13:18 ` Matthew Wilcox
2018-10-15 16:42 ` Darrick J. Wong [this message]
2018-10-13 0:06 ` [PATCH 08/25] vfs: rename vfs_clone_file_prep to be more descriptive Darrick J. Wong
2018-10-13 0:06 ` [PATCH 09/25] vfs: rename clone_verify_area to remap_verify_area Darrick J. Wong
2018-10-13 0:06 ` [PATCH 10/25] vfs: create generic_remap_file_range_touch to update inode metadata Darrick J. Wong
2018-10-14 17:21 ` Christoph Hellwig
2018-10-15 16:30 ` Darrick J. Wong
2018-10-15 18:19 ` Christoph Hellwig
2018-10-13 0:06 ` [PATCH 11/25] vfs: pass remap flags to generic_remap_file_range_prep Darrick J. Wong
2018-10-14 17:22 ` Christoph Hellwig
2018-10-14 17:37 ` Christoph Hellwig
2018-10-15 15:42 ` Darrick J. Wong
2018-10-13 0:07 ` [PATCH 12/25] vfs: pass remap flags to generic_remap_checks Darrick J. Wong
2018-10-13 0:07 ` [PATCH 13/25] vfs: make remap_file_range functions take and return bytes completed Darrick J. Wong
2018-10-13 0:07 ` [PATCH 14/25] vfs: plumb RFR_* remap flags through the vfs clone functions Darrick J. Wong
2018-10-13 0:07 ` [PATCH 15/25] vfs: plumb RFR_* remap flags through the vfs dedupe functions Darrick J. Wong
2018-10-13 0:07 ` [PATCH 16/25] vfs: make remapping to source file eof more explicit Darrick J. Wong
2018-10-14 17:24 ` Christoph Hellwig
2018-10-15 15:32 ` Darrick J. Wong
2018-10-15 18:28 ` Christoph Hellwig
2018-10-13 0:07 ` [PATCH 17/25] vfs: enable remap callers that can handle short operations Darrick J. Wong
2018-10-13 0:07 ` [PATCH 18/25] vfs: hide file range comparison function Darrick J. Wong
2018-10-14 17:43 ` Christoph Hellwig
2018-10-13 0:07 ` [PATCH 19/25] vfs: implement opportunistic short dedupe Darrick J. Wong
2018-10-14 17:26 ` Christoph Hellwig
2018-10-13 0:08 ` [PATCH 20/25] ocfs2: truncate page cache for clone destination file before remapping Darrick J. Wong
2018-10-13 0:08 ` [PATCH 21/25] ocfs2: fix pagecache truncation prior to reflink Darrick J. Wong
2018-10-13 0:08 ` [PATCH 22/25] ocfs2: support partial clone range and dedupe range Darrick J. Wong
2018-10-14 17:41 ` Christoph Hellwig
2018-10-13 0:08 ` [PATCH 23/25] xfs: fix pagecache truncation prior to reflink Darrick J. Wong
2018-10-13 0:08 ` [PATCH 24/25] xfs: support returning partial reflink results Darrick J. Wong
2018-10-14 17:35 ` Christoph Hellwig
2018-10-14 23:05 ` Dave Chinner
2018-10-15 15:49 ` Darrick J. Wong
2018-10-13 0:08 ` [PATCH 25/25] xfs: remove redundant remap partial EOF block checks Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2018-10-11 4:12 [PATCH v3 00/25] fs: fixes for serious clone/dedupe problems Darrick J. Wong
2018-10-11 4:13 ` [PATCH 07/25] vfs: combine the clone and dedupe into a single remap_file_range Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015164220.GL28243@magnolia \
--to=darrick.wong@oracle.com \
--cc=amir73il@gmail.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).