From: "Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>
To: Viacheslav Dubeyko <slava@dubeyko.com>
Cc: linux-fsdevel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] hfsplus: return file attributes on statx
Date: Tue, 16 Oct 2018 22:02:21 -0300 [thread overview]
Message-ID: <20181017010220.b2y3iplop5wfvupf@eaf> (raw)
In-Reply-To: <1539734875.3153.2.camel@slavad-ubuntu-14.04>
On Tue, Oct 16, 2018 at 05:07:55PM -0700, Viacheslav Dubeyko wrote:
> On Tue, 2018-10-16 at 20:38 -0300, Ernesto A. Fernández wrote:
> > On Mon, Oct 15, 2018 at 05:26:23PM -0700, Viacheslav Dubeyko wrote:
> > > On Sun, 2018-10-14 at 13:35 -0300, Ernesto A. Fernández wrote:
> > > > The immutable, append-only and no-dump attributes can only be retrieved
> > > > with an ioctl; implement the ->getattr() method to return them on statx.
> > > > Do not return the inode birthtime yet, because the issue of how best to
> > > > handle the post-2038 timestamps is still under discussion.
> > > >
> > >
> > > As far as I can see, the stable branch doesn't contain the inode
> > > birthtime yet. So, I believe we have no troubles with it.
> >
> > What stable branch? What are you talking about? Of course the inode
> > birthtime is in the code, how could it not be?
> >
>
> I mean the latest stable kernel branch
> (git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git).
OK, that's the stable tree. I still have no idea why you are bringing
it up, or what you mean by "doesn't contain the inode birthtime".
>
> > >
> > > > This patch is needed to pass xfstests generic/424.
> > >
> > > Do you mean that the patch isn't been tested yet? Do it needs to wait
> > > the testing result report before taking the patch? Otherwise, it looks
> > > weird to have such remark in the comment section of the patch.
> >
> > Look, I'm not a native speaker either, but I think that's a pretty simple
> > sentence. You need this patch if you want xfstests generic/424 to pass.
> >
>
> Currently, it sounds confusing.
I don't think it does, and I don't quite trust your judgement in the matter.
> It makes sense to rework the comment
> section and to resend the second version of the patch.
> Thanks,
> Vyacheslav Dubeyko.
>
>
next prev parent reply other threads:[~2018-10-17 8:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-14 16:35 [PATCH] hfsplus: return file attributes on statx Ernesto A. Fernández
2018-10-16 0:26 ` Viacheslav Dubeyko
2018-10-16 23:38 ` Ernesto A. Fernández
2018-10-17 0:07 ` Viacheslav Dubeyko
2018-10-17 1:02 ` Ernesto A. Fernández [this message]
[not found] ` <20181109142630.33f18bf16f7d4d1684c1795d@linux-foundation.org>
2018-11-10 3:26 ` Ernesto A. Fernández
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017010220.b2y3iplop5wfvupf@eaf \
--to=ernesto.mnd.fernandez@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slava@dubeyko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).