From: Phillip Potter <phil@philpotter.co.uk>
To: David Sterba <dsterba@suse.cz>
Cc: clm@fb.com, amir73il@gmail.com, viro@zeniv.linux.org.uk,
jbacik@fb.com, dsterba@suse.com, linux-fsdevel@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: [RFC][PATCH v3 10/10] btrfs: use common file type conversion
Date: Wed, 31 Oct 2018 09:22:31 +0000 [thread overview]
Message-ID: <20181031092231.GC19486@pathfinder> (raw)
In-Reply-To: <20181030190317.GH9136@twin.jikos.cz>
On Tue, Oct 30, 2018 at 08:03:17PM +0100, David Sterba wrote:
> On Sat, Oct 27, 2018 at 01:53:48AM +0100, Phillip Potter wrote:
> > Deduplicate the btrfs file type conversion implementation - file systems
> > that use the same file types as defined by POSIX do not need to define
> > their own versions and can use the common helper functions decared in
> > fs_types.h and implemented in fs_types.c
> >
> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
>
> Acked-by: David Sterba <dsterba@suse.com>
Dear David,
Thanks for this - are you happy for me to move the compile-time tests as per
Amir's suggestion?
Regards,
Phil
next prev parent reply other threads:[~2018-10-31 18:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 0:53 [RFC][PATCH v3 00/10] common implementation of dirent file types Phillip Potter
2018-10-27 0:53 ` [RFC][PATCH v3 10/10] btrfs: use common file type conversion Phillip Potter
2018-10-30 19:03 ` David Sterba
2018-10-31 9:22 ` Phillip Potter [this message]
2018-10-31 15:45 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031092231.GC19486@pathfinder \
--to=phil@philpotter.co.uk \
--cc=amir73il@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).