From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
Date: Thu, 15 Nov 2018 10:30:45 +0100
From: Christoph Hellwig <hch@lst.de>
To: p.jaroszynski@gmail.com
Cc: Christoph Hellwig <hch@lst.de>, Michal Hocko <mhocko@suse.com>,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	Piotr Jaroszynski <pjaroszynski@nvidia.com>
Subject: Re: [PATCH] iomap: get/put the page in iomap_page_create/release()
Message-ID: <20181115093045.GA14847@lst.de>
References: <20181115003000.1358007-1-pjaroszynski@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181115003000.1358007-1-pjaroszynski@nvidia.com>
Sender: owner-linux-mm@kvack.org
List-ID: <linux-fsdevel.vger.kernel.org>

> Fixes: 82cb14175e7d ("xfs: add support for sub-pagesize writeback
>                       without buffer_heads")

I've never seen line breaks in Fixes tags, is this really a valid format?

> +	/*
> +	 * At least migrate_page_move_mapping() assumes that pages with private
> +	 * data have their count elevated by 1.
> +	 */

I'd drop the "At least".

Otherwise this looks fine to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>