From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/2] splice: increase pipe size in splice_direct_to_actor()
Date: Thu, 15 Nov 2018 02:17:35 -0800 [thread overview]
Message-ID: <20181115101735.GC13913@infradead.org> (raw)
In-Reply-To: <20181109005410.GG19305@dastard>
> +long pipe_set_max_safe_size(struct pipe_inode_info *pipe)
> +{
> + pipe_set_size(pipe, pipe_max_size);
> + return pipe->buffers * PAGE_SIZE;
> +}
This should probably return an unsigned value, given that we don't return
errors. Then again the callers ignores the return value entirely.
Wouldn't it be easier to just call pipe_set_size from splice.c after
removing the static marker?
next prev parent reply other threads:[~2018-11-15 20:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 22:19 [PATCH 0/2]: dedupe/copy_file_range fixes Dave Chinner
2018-11-08 22:19 ` [PATCH 1/2] vfs: vfs_dedupe_file_range() doesn't return EOPNOTSUPP Dave Chinner
2018-11-08 23:03 ` Darrick J. Wong
2018-11-09 6:47 ` Darrick J. Wong
2018-11-16 5:33 ` Dave Chinner
2018-11-08 22:19 ` [PATCH 2/2] iomap: dio data corruption and spurious errors when pipes fill Dave Chinner
2018-11-13 16:25 ` Darrick J. Wong
2018-11-15 10:15 ` Christoph Hellwig
2018-11-09 0:54 ` [PATCH 3/2] splice: increase pipe size in splice_direct_to_actor() Dave Chinner
2018-11-13 16:22 ` Darrick J. Wong
2018-11-13 21:41 ` Dave Chinner
2018-11-15 10:17 ` Christoph Hellwig [this message]
2018-11-16 5:42 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115101735.GC13913@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).