From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.211]:50772 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728124AbeKQCIi (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 16 Nov 2018 21:08:38 -0500
Date: Fri, 16 Nov 2018 16:55:42 +0100
From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
        Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
        Eric Sandeen <sandeen@redhat.com>,
        Christoph Hellwig <hch@lst.de>,
        Dave Chinner <david@fromorbit.com>,
        "Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: [PATCH 15/20] fiemap: Start using new callback from fiemap_ctx
Message-ID: <20181116155542.GH15119@lst.de>
References: <20181030131823.29040-1-cmaiolino@redhat.com> <20181030131823.29040-16-cmaiolino@redhat.com> <9E0BA794-2D0F-43B8-814D-6BDFA500DD2C@dilger.ca> <20181106085203.cvncdzndhjnnybrv@odin.usersys.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181106085203.cvncdzndhjnnybrv@odin.usersys.redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Nov 06, 2018 at 09:52:03AM +0100, Carlos Maiolino wrote:
> Not really, because fiemap_extent_info has (had now) a userspace pointer, which
> isn't used in FIBMAP calls in later patches, so the idea of using callbacks
> started as a need to use different code workflow, depending on the user of (now
> deprecated) fiemap_extent_info

Well, we could also change that member of fiemap_extent_info if we
really wanted to.  Not sure that would be the better route, though.