From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, Phillip Potter <phil@philpotter.co.uk>,
Jan Kara <jack@suse.com>, Al Viro <viro@zeniv.linux.org.uk>,
Ext4 <linux-ext4@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC][PATCH v4 04/09] ext2: use common file type conversion
Date: Tue, 27 Nov 2018 09:56:53 +0100 [thread overview]
Message-ID: <20181127085653.GC14128@quack2.suse.cz> (raw)
In-Reply-To: <CAOQ4uxiOOJuFDO7x=sY9Cy3wGr8xo6AGKY4Hep10jwvOVkqd_A@mail.gmail.com>
On Thu 22-11-18 14:47:39, Amir Goldstein wrote:
> On Thu, Nov 22, 2018 at 1:40 PM Jan Kara <jack@suse.cz> wrote:
> >
> > On Wed 21-11-18 19:06:53, Phillip Potter wrote:
> > > Deduplicate the ext2 file type conversion implementation - file systems
> > > that use the same file types as defined by POSIX do not need to define
> > > their own versions and can use the common helper functions decared in
> > > fs_types.h and implemented in fs_types.c
> > >
> > > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> > > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> >
> > Looks good. You can add:
> >
> > Reviewed-by: Jan Kara <jack@suse.cz>
>
> Jan,
>
> As you know, Al probably has bigger fish to fry at the moment.
> Will you take this patch along with patch #1 through your tree?
> Other fs maintainers could apply patches on next cycle (or coordinate
> they pull request with you).
>
> If you would agree to that, I suggest to copy the following section
> from the cover letter into the ext2 patch:
>
> The current implementation has a lurking out-of-bounds access
> bug to the ext2_type_by_mode array.
> The array is defined with size S_IFMT >> S_SHIFT, so 15.
> This means that it is possible with a malformed inode to
> get an index of 15, as the array is always accessed with:
> ext2_type_by_mode[(mode & S_IFMT)>>S_SHIFT];
Yes, I will do that.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2018-11-27 19:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 19:06 [RFC][PATCH v4 04/09] ext2: use common file type conversion Phillip Potter
2018-11-22 11:40 ` Jan Kara
2018-11-22 12:47 ` Amir Goldstein
2018-11-27 8:56 ` Jan Kara [this message]
2018-11-22 14:42 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127085653.GC14128@quack2.suse.cz \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=phil@philpotter.co.uk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).