From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:33956 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728832AbeK2BpM (ORCPT ); Wed, 28 Nov 2018 20:45:12 -0500 Date: Wed, 28 Nov 2018 15:43:16 +0100 From: Jan Kara To: Amir Goldstein Cc: Jan Kara , Matthew Bobrowski , linux-fsdevel Subject: Re: [PATCH v3 01/13] fsnotify: annotate directory entry modification events Message-ID: <20181128144316.GH15604@quack2.suse.cz> References: <20181125134352.21499-1-amir73il@gmail.com> <20181125134352.21499-2-amir73il@gmail.com> <20181128125903.GE15604@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed 28-11-18 16:39:31, Amir Goldstein wrote: > On Wed, Nov 28, 2018 at 2:59 PM Jan Kara wrote: > > > +/* > > > + * This is a list of all events that may get sent to a parent based on fs event > > > > ^^^ Line too long. > > Heh?? checkpatch did not complain. It's 79 chars. My bad, just the quoting in the reply pushed the line over 80 chars and I didn't realize that. > > > > > +#define ALL_FSNOTIFY_EVENTS (ALL_FSNOTIFY_DIRENT_EVENTS| \ > > ^^^ space here > > > > My patch did not change indentation AFAIK. > The new definition added is with tab (ALL_FSNOTIFY_DIRENT_EVENTS) > but some of the existing definitions, even ones moved around are with space(s). > Do you want me to change that? This is not about indentation but space before '|' operator... Honza -- Jan Kara SUSE Labs, CR