From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 28 Nov 2018 09:10:04 -0800 From: Matthew Wilcox To: Dan Williams Cc: Jan Kara , Dave Jiang , linux-nvdimm , linux-fsdevel , stable Subject: Re: [PATCH 2/2] dax: Don't access a freed inode Message-ID: <20181128171004.GI10377@bombadil.infradead.org> References: <20181127211634.4995-1-willy@infradead.org> <20181127211634.4995-3-willy@infradead.org> <20181128115330.GB15604@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Wed, Nov 28, 2018 at 09:08:40AM -0800, Dan Williams wrote: > > Can we add a comment here like: > > > > /* > > * Entry lock waits are exclusive. Wake up the next waiter since we > > * aren't sure we will acquire the entry lock and thus wake the > > * next waiter up on unlock. > > */ > > > > Because I always wonder for a moment why this is needed. > > Looks good, I'll add that when applying. Thanks.