From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Jan Kara <jack@suse.cz>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH RFC 12/15] inotify: replace **** with a hug
Date: Wed, 5 Dec 2018 10:49:13 +0100 [thread overview]
Message-ID: <20181205094913.GC22304@quack2.suse.cz> (raw)
In-Reply-To: <CAOQ4uxiXqt+r64mtJUejzq6JTMcH-DYPsd609SdqWj5UOfZUjw@mail.gmail.com>
On Sat 01-12-18 08:40:25, Amir Goldstein wrote:
> On Fri, Nov 30, 2018 at 9:27 PM Jarkko Sakkinen
> <jarkko.sakkinen@linux.intel.com> wrote:
> >
> > In order to comply with the CoC, replace **** with a hug.
> >
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > ---
> > fs/notify/inotify/inotify_user.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c
> > index 105576daca4a..db0b3b6d6a58 100644
> > --- a/fs/notify/inotify/inotify_user.c
> > +++ b/fs/notify/inotify/inotify_user.c
> > @@ -446,7 +446,7 @@ static void inotify_remove_from_idr(struct fsnotify_group *group,
> > /*
> > * We found an mark in the idr at the right wd, but it's
> > * not the mark we were told to remove. eparis seriously
> > - * fucked up somewhere.
> > + * hugged up somewhere.
> > */
> > if (unlikely(found_i_mark != i_mark)) {
> > WARN_ONCE(1, "%s: i_mark=%p i_mark->wd=%d i_mark->group=%p "
>
>
> LoL. doesn't shaming conflict with the CoC?
> Just remove this sentence - it adds no valuable information.
> While at it, please fix grammar "a mark".
Agreed, just send a patch to remove that sentence and fixup the article.
Btw, for the fun of it Eric has added this comment himself so I don't think
this would really qualify as a CoC violation ;)
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2018-12-05 9:49 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 19:27 [PATCH RFC 00/15] Zero ****s, hugload of hugs <3 Jarkko Sakkinen
2018-11-30 19:27 ` [PATCH RFC 12/15] inotify: replace **** with a hug Jarkko Sakkinen
2018-12-01 6:40 ` Amir Goldstein
2018-12-05 9:49 ` Jan Kara [this message]
2018-11-30 19:40 ` [PATCH RFC 00/15] Zero ****s, hugload of hugs <3 Kees Cook
2018-11-30 19:56 ` Davidlohr Bueso
2018-11-30 20:12 ` Jens Axboe
2018-11-30 20:34 ` Michael Schmitz
2018-11-30 20:35 ` David Miller
[not found] ` <20181130.123507.1940310466680455876.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2018-11-30 20:39 ` Abuse
2018-11-30 20:42 ` David Miller
[not found] ` <20181130.124228.979846577878820546.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2018-11-30 20:45 ` Abuse
2018-11-30 20:43 ` Steven Rostedt
2018-12-01 4:08 ` Jarkko Sakkinen
2018-11-30 21:42 ` Jarkko Sakkinen
2018-11-30 21:47 ` David Miller
2018-11-30 21:53 ` Jens Axboe
2018-11-30 20:34 ` David Miller
2018-11-30 20:55 ` Jarkko Sakkinen
2018-11-30 21:01 ` James Bottomley
2018-11-30 21:44 ` Jarkko Sakkinen
2018-11-30 21:48 ` David Miller
2018-11-30 21:54 ` Jarkko Sakkinen
2018-11-30 22:04 ` James Bottomley
2018-11-30 21:57 ` James Bottomley
2018-11-30 22:12 ` Jarkko Sakkinen
2018-11-30 22:14 ` Jonathan Corbet
2018-11-30 22:26 ` Jarkko Sakkinen
2018-11-30 22:29 ` Jarkko Sakkinen
2018-11-30 22:30 ` James Bottomley
2018-11-30 22:40 ` Jarkko Sakkinen
2018-11-30 23:28 ` Jarkko Sakkinen
2018-12-01 8:20 ` Geert Uytterhoeven
2018-12-07 13:39 ` Eric Curtin
2018-11-30 22:26 ` James Bottomley
2018-11-30 21:02 ` Steven Rostedt
2018-11-30 21:04 ` Jonathan Corbet
2018-11-30 20:09 ` John Paul Adrian Glaubitz
2018-11-30 21:32 ` Jarkko Sakkinen
2018-11-30 20:31 ` Matthias Brugger
2018-11-30 21:34 ` Jarkko Sakkinen
2018-11-30 20:42 ` Chris Mason
2018-11-30 21:36 ` Jarkko Sakkinen
2018-11-30 21:07 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205094913.GC22304@quack2.suse.cz \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).