From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:57520 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727815AbeLMQ1T (ORCPT ); Thu, 13 Dec 2018 11:27:19 -0500 Date: Thu, 13 Dec 2018 08:27:18 -0800 From: Matthew Wilcox To: Goldwyn Rodrigues Cc: linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, avi@scylladb.com Subject: Re: [PATCH] fs: Return EOPNOTSUPP if block layer does not support REQ_NOWAIT Message-ID: <20181213162718.GP6830@bombadil.infradead.org> References: <20181213115306.fm2mjc3qszjiwkgf@merlin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181213115306.fm2mjc3qszjiwkgf@merlin> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Dec 13, 2018 at 05:53:06AM -0600, Goldwyn Rodrigues wrote: > For AIO+DIO with RWF_NOWAIT, if the block layer does not support REQ_NOWAIT, > it returns EIO. Return EOPNOTSUPP to represent the correct error code. Why is EOPNOTSUPP the "correct" error code? That's a networking error, not a block layer error.