From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:57742 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727384AbeLQRiP (ORCPT ); Mon, 17 Dec 2018 12:38:15 -0500 Date: Mon, 17 Dec 2018 09:38:13 -0800 From: Christoph Hellwig To: Avi Kivity Cc: Christoph Hellwig , Goldwyn Rodrigues , linux-fsdevel@vger.kernel.org, linux-aio@kvack.org Subject: Re: [PATCH] fs: Return EOPNOTSUPP if block layer does not support REQ_NOWAIT Message-ID: <20181217173813.GB10437@infradead.org> References: <20181213115306.fm2mjc3qszjiwkgf@merlin> <38b8f7a9-cf95-e165-4e9a-40ddcfe6bed2@scylladb.com> <20181213142434.GA3239@infradead.org> <0bafdaea-a787-fadb-5da8-06b9e0042840@scylladb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0bafdaea-a787-fadb-5da8-06b9e0042840@scylladb.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Dec 16, 2018 at 12:45:19PM +0200, Avi Kivity wrote: > I did see this on XFS too. The whole thing bothers me, it doesn't happen > consistently in some setups, which I don't understand. Either it should > trigger always or never. Well, if it also happens in XFS the above change isn't going to fix it alone, there must be another issue hiding in addition to the error conversion problems.