From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:55154 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726430AbeLRLz2 (ORCPT ); Tue, 18 Dec 2018 06:55:28 -0500 Date: Tue, 18 Dec 2018 05:55:24 -0600 From: Goldwyn Rodrigues To: Christoph Hellwig Cc: Avi Kivity , linux-fsdevel@vger.kernel.org, linux-aio@kvack.org Subject: Re: [PATCH] fs: Return EOPNOTSUPP if block layer does not support REQ_NOWAIT Message-ID: <20181218115524.lt3dm53vgmbdbxjd@merlin> References: <20181213115306.fm2mjc3qszjiwkgf@merlin> <38b8f7a9-cf95-e165-4e9a-40ddcfe6bed2@scylladb.com> <20181213142434.GA3239@infradead.org> <0bafdaea-a787-fadb-5da8-06b9e0042840@scylladb.com> <20181217173813.GB10437@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181217173813.GB10437@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 9:38 17/12, Christoph Hellwig wrote: > On Sun, Dec 16, 2018 at 12:45:19PM +0200, Avi Kivity wrote: > > I did see this on XFS too. The whole thing bothers me, it doesn't happen > > consistently in some setups, which I don't understand. Either it should > > trigger always or never. > > Well, if it also happens in XFS the above change isn't going to fix > it alone, there must be another issue hiding in addition to the error > conversion problems. Are you using multi-device setup as your block device? That could make it return EOPNOTSUPP since we never got to a point where we could merge code which supported bio based devices. -- Goldwyn