archive mirror
 help / color / mirror / Atom feed
From: Eric Biggers <>
To:, Alexander Viro <>
Subject: [PATCH RESEND] fs/buffer.c: include fs/internal.h for missing prototypes
Date: Thu, 10 Jan 2019 12:40:41 -0800	[thread overview]
Message-ID: <> (raw)

From: Eric Biggers <>

__block_write_begin_int(), __generic_write_end(), and guard_bio_eod()
are defined in fs/buffer.c and declared in fs/internal.h, but the
declarations aren't included at the point of the definitions.  Include
the header to enforce that the definitions match the declarations.

This addresses gcc warnings when -Wmissing-prototypes is enabled.

Signed-off-by: Eric Biggers <>
 fs/buffer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/buffer.c b/fs/buffer.c
index 52d024bfdbc12..7a9937b0cb9f3 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -46,6 +46,7 @@
 #include <linux/pagevec.h>
 #include <linux/sched/mm.h>
 #include <trace/events/block.h>
+#include "internal.h"
 static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
 static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,

             reply	other threads:[~2019-01-10 20:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 20:40 Eric Biggers [this message]
2019-02-07 23:40 ` [PATCH RESEND] fs/buffer.c: include fs/internal.h for missing prototypes Eric Biggers
2019-08-22 15:39 Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).