From: Ian Kent <raven@themaw.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: autofs mailing list <autofs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pan Bian <bianpan2016@163.com>
Subject: [PATCH 2/3] autofs - fix error return in autofs_fill_super()
Date: Sat, 12 Jan 2019 08:00:33 +0800 [thread overview]
Message-ID: <154725123240.11260.796773942606871359.stgit@pluto-themaw-net> (raw)
Message-ID: <20190112000033.stMRigpY4QpPmIdgKX-Md1suIFrnWroBOE_xMNpkkY4@z> (raw)
In-Reply-To: <154725122396.11260.16053424107144453867.stgit@pluto-themaw-net>
In autofs_fill_super() on error of get inode/make root dentry the
return should be ENOMEM as this is the only failure case of the
called functions.
Signed-off-by: Ian Kent <raven@themaw.net>
---
fs/autofs/inode.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/autofs/inode.c b/fs/autofs/inode.c
index 0e8ea2d9a2bb..078992eee299 100644
--- a/fs/autofs/inode.c
+++ b/fs/autofs/inode.c
@@ -266,8 +266,10 @@ int autofs_fill_super(struct super_block *s, void *data, int silent)
}
root_inode = autofs_get_inode(s, S_IFDIR | 0755);
root = d_make_root(root_inode);
- if (!root)
+ if (!root) {
+ ret = -ENOMEM;
goto fail_ino;
+ }
pipe = NULL;
root->d_fsdata = ino;
next prev parent reply other threads:[~2019-01-12 0:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 0:00 [PATCH 1/3] autofs: drop dentry reference only when it is never used Ian Kent
2019-01-12 0:00 ` Ian Kent
2019-01-12 0:00 ` Ian Kent [this message]
2019-01-12 0:00 ` [PATCH 2/3] autofs - fix error return in autofs_fill_super() Ian Kent
2019-01-12 0:00 ` [PATCH 3/3] autofs: add ignore mount option Ian Kent
2019-01-12 0:00 ` Ian Kent
2019-01-30 1:16 ` Andrew Morton
2019-01-30 2:07 ` Ian Kent
2019-01-30 2:44 ` Ian Kent
2019-01-30 4:18 ` Al Viro
2019-01-30 4:45 ` Ian Kent
2019-01-30 4:58 ` Andrew Morton
2019-01-30 5:20 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154725123240.11260.796773942606871359.stgit@pluto-themaw-net \
--to=raven@themaw.net \
--cc=akpm@linux-foundation.org \
--cc=autofs@vger.kernel.org \
--cc=bianpan2016@163.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).