From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FC18C43387 for ; Mon, 14 Jan 2019 16:53:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3624B206B7 for ; Mon, 14 Jan 2019 16:53:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726753AbfANQxq (ORCPT ); Mon, 14 Jan 2019 11:53:46 -0500 Received: from verein.lst.de ([213.95.11.211]:47742 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726680AbfANQxq (ORCPT ); Mon, 14 Jan 2019 11:53:46 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id B5CFE68D93; Mon, 14 Jan 2019 17:53:44 +0100 (CET) Date: Mon, 14 Jan 2019 17:53:44 +0100 From: Christoph Hellwig To: Carlos Maiolino Cc: linux-fsdevel@vger.kernel.org, hch@lst.de, adilger@dilger.ca, sandeen@redhat.com, david@fromorbit.com Subject: Re: [PATCH 08/10 V2] fiemap: Use a callback to fill fiemap extents Message-ID: <20190114165344.GF7187@lst.de> References: <20181205091728.29903-1-cmaiolino@redhat.com> <20181205091728.29903-9-cmaiolino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181205091728.29903-9-cmaiolino@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Dec 05, 2018 at 10:17:26AM +0100, Carlos Maiolino wrote: > As a goal to enable fiemap infrastructure to be used by fibmap too, we need a > way to use different helpers to fill extent data, depending on its usage. One > helper to fill extent data stored in user address space (used in fiemap), and > another fo fill extent data stored in kernel address space (will be used in > fibmap). > > This patch sets up the usage of a callback to be used to fill in the extents. > It transforms the current fiemap_fill_next_extent, into a simple helper to call > the callback, avoiding unneeded changes on any filesystem, and reutilizes the > original function as the callback used by FIEMAP. Looks good modulo the fact that the previous patch should be merged into this one.