From: Matthew Wilcox <willy@infradead.org>
To: Phillip Potter <phil@philpotter.co.uk>
Cc: viro@zeniv.linux.org.uk, jack@suse.cz, amir73il@gmail.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][PATCH v5 00/09] common implementation of dirent file types
Date: Mon, 21 Jan 2019 01:35:10 -0800 [thread overview]
Message-ID: <20190121093510.GA11365@bombadil.infradead.org> (raw)
In-Reply-To: <20190121005425.GA32315@pathfinder>
On Mon, Jan 21, 2019 at 12:54:25AM +0000, Phillip Potter wrote:
> These patches mostly no longer include compile-time checks to ensure
> the filesystem specific on-disk bits are equivalent to the common
> implementation FT_* bits, and instead op to remove the filesystem
> specific definitions entirely where possible, as a result of the
> referenced discussion above.
>
> With the ext4 patch, the EXT4_FT_* definitions are instead defined
> to be FT_*, to give less code churn with the same result (no need
> to modify fs/ext4/namei.c). Also, the nilfs2 and btrfs filesystems
> keep their filesystem specific definitions in the include/uapi/linux
> directory, so these cannot be changed trivially without breaking
> userspace. For this reason, the compile time checks remain in these
> two filesystems.
Just because something is exposed through the uapi directory today
doesn't mean userspace actually uses it. For example,
https://codesearch.debian.net/search?q=BTRFS_FT_DIR
The only code which uses the filetype defines is going to be code which
actually looks at a raw filesystem image. All three examples of userspace
code in Debian have their own definitions instead of using the one which
the kernel provides.
next prev parent reply other threads:[~2019-01-21 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 0:54 [RFC][PATCH v5 00/09] common implementation of dirent file types Phillip Potter
2019-01-21 9:35 ` Matthew Wilcox [this message]
2019-01-21 11:22 ` Amir Goldstein
2019-01-22 9:58 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121093510.GA11365@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=phil@philpotter.co.uk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).