From: Christian Brauner <christian@brauner.io>
To: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
dhowells@redhat.com
Cc: tkjos@google.com, Christian Brauner <christian@brauner.io>
Subject: [PATCH v1 0/7] binderfs: debug galore
Date: Mon, 21 Jan 2019 11:48:01 +0100 [thread overview]
Message-ID: <20190121104808.24108-1-christian@brauner.io> (raw)
Hey everyone,
Al gave me a really helpful review of binderfs and pointed out a range
of bugs. The most obvious and serious ones have fortunately already been
taken care of by patches sitting in Greg's char-misc-linus tree. The
others are hopefully all covered in this patchset.
/* Changelog */
Nothing major apart from working in a bunch of good comments and
suggestions from Al. The most interesting one is probably the switch
from d_alloc_name() + d_lookup() to lookup_one_len() when detecting name
clashes between binder devices. This also forces us to switch from
d_add() to d_instantiate() since lookup_one_len() adds new dentries to
the hashqueue. If we were to use d_add() after this we'd end up with the
same dentry over the same inode twice. I moved the switch from d_add()
to d_instantiate() into a separate commit.
The rest should hopefully be pretty mundane.
Thanks!
Christian
Christian Brauner (7):
binderfs: remove outdated comment
binderfs: prevent renaming the control dentry
binderfs: rework binderfs_fill_super()
binderfs: rework binderfs_binder_device_create()
binderfs: kill_litter_super() before cleanup
binderfs: drop lock in binderfs_binder_ctl_create
binderfs: switch from d_add() to d_instantiate()
drivers/android/binderfs.c | 121 +++++++++++++------------------------
1 file changed, 43 insertions(+), 78 deletions(-)
--
2.19.1
next reply other threads:[~2019-01-21 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 10:48 Christian Brauner [this message]
2019-01-21 10:48 ` [PATCH v1 1/7] binderfs: remove outdated comment Christian Brauner
2019-01-21 10:48 ` [PATCH v1 2/7] binderfs: prevent renaming the control dentry Christian Brauner
2019-01-21 10:48 ` [PATCH v1 3/7] binderfs: rework binderfs_fill_super() Christian Brauner
2019-01-21 10:48 ` [PATCH v1 4/7] binderfs: rework binderfs_binder_device_create() Christian Brauner
2019-01-21 10:48 ` [PATCH v1 5/7] binderfs: kill_litter_super() before cleanup Christian Brauner
2019-01-21 10:48 ` [PATCH v1 6/7] binderfs: drop lock in binderfs_binder_ctl_create Christian Brauner
2019-01-21 10:48 ` [PATCH v1 7/7] binderfs: switch from d_add() to d_instantiate() Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121104808.24108-1-christian@brauner.io \
--to=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tkjos@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).