From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0766FC282C3 for ; Thu, 24 Jan 2019 09:29:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C12A221872 for ; Thu, 24 Jan 2019 09:29:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=philpotter-co-uk.20150623.gappssmtp.com header.i=@philpotter-co-uk.20150623.gappssmtp.com header.b="avq7AT/w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725987AbfAXJ3O (ORCPT ); Thu, 24 Jan 2019 04:29:14 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:33493 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725931AbfAXJ3O (ORCPT ); Thu, 24 Jan 2019 04:29:14 -0500 Received: by mail-wr1-f67.google.com with SMTP id p7so5692576wru.0 for ; Thu, 24 Jan 2019 01:29:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=z3+RiNjBBmO+ociBSMjDe/JMePubkuee/nrAQg80foQ=; b=avq7AT/wMNF94eF9jInDbxFqR3C3y3enZ2ITSaJUdV8XlnUVCArf3ENrnrp7VDb+Jy 7m+JT1CtsRohk1k3D6L/mqiLF95tDHMClCjhxMNxG9WW7CClL6EASGovv2LHD+VicMwT Sm6z8yyTXBuNcc/Wrt1orXsvQM6xeoHYIye5KSTFn4RP5LLlHnVXAK98fwnfLM112eyw xHaDPArqDcdrwwrDtseveWzOdCNx1epKklI8pe++9LbEg/X0Fhsxz9AkwIGZ5QeMgA+9 rGX0wJhSuAUTg3K4abf9GgUQwFG2iKF8Y8l5JYebguyMCy+ZdNBzg+ZborrHA0xES4mg 5hWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=z3+RiNjBBmO+ociBSMjDe/JMePubkuee/nrAQg80foQ=; b=Cs0HMYTgzIEXujt7RzYInQuLqEtdsxzEgr+JpEsv8/NqQJealMIMDrv9xM3OmDLQLD 9+o7wd+kf+2P25uUX6d+mesCcPV3XFfBATJBaEXUvo8CfBQoUmVMfsv55JD35aXiO7ts 8NXd+5KIEmeJhrUclOSxhB5GB+k5gZXeNIf8M0YcUl+U7caz1jvZNxHyY63XPgNKvJ0+ DELIjY4COnAYfintcs23fLa40Cc50pPLwkegMbSjzS5ZHx4SKrKXRLkZr1QeyvXEDFJC GlSSXCqNWVtw2/MZ6k4jyUrRxxviZA5LgWYSQLtQlcBBaBIgJ6Zf0MQAM2o3DL0aYfsc 9p4g== X-Gm-Message-State: AJcUukfCmqW/WiIOMASXO26iaafXQJSfkUy0CsecuPP5u+n1OHPpr7gp vIudJYOMGTd3O/cPTfbx65u7vQ== X-Google-Smtp-Source: ALg8bN7lESwzykNIekSh/foBNur6F+Ae3ZVAAlQCJDSIKIE1iIW3K4c76pFUiXxED2zmceHUudiTEQ== X-Received: by 2002:a5d:570c:: with SMTP id a12mr6176666wrv.161.1548322152243; Thu, 24 Jan 2019 01:29:12 -0800 (PST) Received: from pathfinder ([90.222.17.17]) by smtp.gmail.com with ESMTPSA id a18sm124274944wrp.13.2019.01.24.01.29.11 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 24 Jan 2019 01:29:11 -0800 (PST) Date: Thu, 24 Jan 2019 09:29:09 +0000 From: Phillip Potter To: Jan Kara Cc: mark@fasheh.com, amir73il@gmail.com, viro@zeniv.linux.org.uk, jlbec@evilplan.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: Re: [RFC][PATCH v5 05/09] ocfs2: use common file type conversion Message-ID: <20190124092909.GB25629@pathfinder> References: <20190121005432.GA32351@pathfinder> <20190123114803.GB20927@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190123114803.GB20927@quack2.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jan 23, 2019 at 12:48:03PM +0100, Jan Kara wrote: > On Mon 21-01-19 00:54:32, Phillip Potter wrote: > > Deduplicate the ocfs2 file type conversion implementation and remove > > OCFS2_FT_* definitions - file systems that use the same file types > > as defined by POSIX do not need to define their own versions and can > > use the common helper functions decared in fs_types.h and implemented > > in fs_types.c > > > > Signed-off-by: Amir Goldstein > > Signed-off-by: Phillip Potter > > The patch looks good to me. You can add: > > Reviewed-by: Jan Kara > > Honza Thank you very much Jan. Regards, Phil