From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=xEkS=QE=vger.kernel.org=linux-fsdevel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 7882CC282CF
	for <linux-fsdevel@archiver.kernel.org>; Mon, 28 Jan 2019 14:26:02 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 541B42171F
	for <linux-fsdevel@archiver.kernel.org>; Mon, 28 Jan 2019 14:26:02 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726719AbfA1O0B (ORCPT
        <rfc822;linux-fsdevel@archiver.kernel.org>);
        Mon, 28 Jan 2019 09:26:01 -0500
Received: from verein.lst.de ([213.95.11.211]:39912 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726266AbfA1O0B (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Mon, 28 Jan 2019 09:26:01 -0500
Received: by newverein.lst.de (Postfix, from userid 2407)
        id AED5268DCF; Mon, 28 Jan 2019 15:25:59 +0100 (CET)
Date:   Mon, 28 Jan 2019 15:25:59 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Jens Axboe <axboe@kernel.dk>
Cc:     linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
        linux-block@vger.kernel.org, hch@lst.de, jmoyer@redhat.com,
        avi@scylladb.com
Subject: Re: [PATCH 01/18] fs: add an iopoll method to struct
 file_operations
Message-ID: <20190128142559.GA9563@lst.de>
References: <20190123153536.7081-1-axboe@kernel.dk> <20190123153536.7081-2-axboe@kernel.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190123153536.7081-2-axboe@kernel.dk>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-fsdevel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-fsdevel.vger.kernel.org>
X-Mailing-List: linux-fsdevel@vger.kernel.org

On Wed, Jan 23, 2019 at 08:35:12AM -0700, Jens Axboe wrote:
> TODO: we can probably union ki_cookie with the existing hint and I/O
> priority fields to avoid struct kiocb growth.

Please kill this comment.  While this should be doable the semantics
would be a bit nasty, so unless we have to I'd rather skip this work
for now.