From: Karel Zak <kzak@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: David Howells <dhowells@redhat.com>,
linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
Miklos Szeredi <miklos@szeredi.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
util-linux@vger.kernel.org, Andy Lutomirski <luto@amacapital.net>
Subject: Re: [RFD] A mount api that notices previous mounts
Date: Wed, 30 Jan 2019 19:00:51 +0100 [thread overview]
Message-ID: <20190130180051.caonbh2t7wtsdqo5@ws.net.home> (raw)
In-Reply-To: <87h8dqs1xw.fsf@xmission.com>
On Wed, Jan 30, 2019 at 07:35:39AM -0600, Eric W. Biederman wrote:
> I suspect that as long as userspace supports /etc/fstab and we in turn
> support /proc/mounts there is going to be a lot of pressure to keep
> the majority of options so they can be encoded in a string separated by
> commas.
Well, we're doing many crazy things in userspace ;-) For example we do
not distinguish between VFS flags (MS_*), FS specific mount options
and userspace mount options (loop=) in our config files.
You already need to parse fstab/command line before you can use the
strings for mount(2) syscall. It's already not straightforward, see
all the code in libmount...
/proc/mounts is only for backward compatibility, /proc/self/mountinfo
is better way, because it allows to see VFS and FS, etc.
IMHO it would be better to not care about way how we use mount options
strings now (in userspace) when you think about the new API design.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2019-01-30 18:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 21:44 [RFD] A mount api that notices previous mounts Eric W. Biederman
2019-01-29 23:01 ` Casey Schaufler
2019-01-30 1:15 ` Eric W. Biederman
2019-01-30 1:23 ` Eric W. Biederman
2019-01-30 12:47 ` Eric W. Biederman
2019-01-30 16:19 ` Casey Schaufler
2019-01-30 12:06 ` Karel Zak
2019-01-30 13:45 ` Eric W. Biederman
2019-01-30 12:50 ` David Howells
2019-01-30 13:24 ` Eric W. Biederman
2019-01-30 13:01 ` David Howells
2019-01-30 13:35 ` Eric W. Biederman
2019-01-30 18:00 ` Karel Zak [this message]
2019-01-30 17:43 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130180051.caonbh2t7wtsdqo5@ws.net.home \
--to=kzak@redhat.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
--cc=util-linux@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).