From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7239C169C4 for ; Thu, 31 Jan 2019 20:34:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FC8F218AC for ; Thu, 31 Jan 2019 20:34:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727725AbfAaUeF (ORCPT ); Thu, 31 Jan 2019 15:34:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52712 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726848AbfAaUeF (ORCPT ); Thu, 31 Jan 2019 15:34:05 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9B8B9432B8; Thu, 31 Jan 2019 20:34:04 +0000 (UTC) Received: from redhat.com (unknown [10.20.6.236]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 619A860BF7; Thu, 31 Jan 2019 20:34:01 +0000 (UTC) Date: Thu, 31 Jan 2019 15:33:59 -0500 From: Jerome Glisse To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christian =?iso-8859-1?Q?K=F6nig?= , Jan Kara , Felix Kuehling , Jason Gunthorpe , Matthew Wilcox , Ross Zwisler , Dan Williams , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Michal Hocko , Ralph Campbell , John Hubbard , kvm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-fsdevel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH v4 0/9] mmu notifier provide context informations Message-ID: <20190131203359.GA22145@redhat.com> References: <20190123222315.1122-1-jglisse@redhat.com> <20190131161006.GA16593@redhat.com> <20190131115535.7eeecf501615f8bad2f139eb@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190131115535.7eeecf501615f8bad2f139eb@linux-foundation.org> User-Agent: Mutt/1.10.0 (2018-05-17) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 31 Jan 2019 20:34:04 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jan 31, 2019 at 11:55:35AM -0800, Andrew Morton wrote: > On Thu, 31 Jan 2019 11:10:06 -0500 Jerome Glisse wrote: > > > Andrew what is your plan for this ? I had a discussion with Peter Xu > > and Andrea about change_pte() and kvm. Today the change_pte() kvm > > optimization is effectively disabled because of invalidate_range > > calls. With a minimal couple lines patch on top of this patchset > > we can bring back the kvm change_pte optimization and we can also > > optimize some other cases like for instance when write protecting > > after fork (but i am not sure this is something qemu does often so > > it might not help for real kvm workload). > > > > I will be posting a the extra patch as an RFC, but in the meantime > > i wanted to know what was the status for this. > > The various drm patches appear to be headed for collisions with drm > tree development so we'll need to figure out how to handle that and in > what order things happen. > > It's quite unclear from the v4 patchset's changelogs that this has > anything to do with KVM and "the change_pte() kvm optimization" hasn't > been described anywhere(?). > > So.. I expect the thing to do here is to get everything finished, get > the changelogs completed with this new information and do a resend. > > Can we omit the drm and rdma patches for now? Feed them in via the > subsystem maintainers when the dust has settled? Yes, i should have pointed out that you can ignore the driver patches i will resumit them through the appropriate tree once the mm bits are in. I just wanted to show case how i intended to use this. I will try not to forget next time to clearly tag things that are just there to show case and that will be merge latter through different tree. I will do a v5 with kvm bits once we have enough testing and confidence. So i guess this all will be delayed to 5.2 and 5.3 for driver bits. The kvm bits are outcomes of private emails and previous face to face discussion around mmu notifier and kvm. I believe the context information will turn to be useful to more users than the ones i am doing it for. Cheers, Jérôme