From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58DF1C282CB for ; Tue, 5 Feb 2019 19:13:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C1E5217F9 for ; Tue, 5 Feb 2019 19:13:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549394023; bh=5FhIwDXt88N2ntLd/87stH4q1oBGySVn3FBYbJgAqPo=; h=From:To:Cc:Subject:Date:List-ID:From; b=0gQ8o4Kv0yPDSs8e//0ohppoRtqmEbIWolDgZBgabcVQCJWHSbipCVBRGTxR9lmTq b3jxdDJnYCkuzxTBF1Y1t95veIIVJM0QqMikLgutEvHAl/Jq1+9N/VoGiuiWMSZJLK wagOVDZ5kKiBJ8NEwkkir1595agcVxJ4kMtbL47Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726550AbfBETNm (ORCPT ); Tue, 5 Feb 2019 14:13:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:51084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725921AbfBETNm (ORCPT ); Tue, 5 Feb 2019 14:13:42 -0500 Received: from hubcapsc.localdomain (adsl-108-140-7-244.gsp.bellsouth.net [108.140.7.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CFFC12083B; Tue, 5 Feb 2019 19:13:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549394021; bh=5FhIwDXt88N2ntLd/87stH4q1oBGySVn3FBYbJgAqPo=; h=From:To:Cc:Subject:Date:From; b=GAMOsHeQ4kze/+IYPyk0qu5tTNsli4PW2wHdt7xgTem/xPYshatu3byOCYyGegSIk LOJw/WDn+qbT3inIbhIym7OmZs64DHd6L/6R/oJStCJXAu/E1wABCt0iQktj4mSJV2 oxH8kpJ0mpDGY7RCqM+Qt/I5dQW1MSns/WGAxWXk= From: hubcap@kernel.org To: linux-fsdevel@vger.kernel.org Cc: Mike Marshall , viro@zeniv.linux.org.uk, axboe@kernel.dk, hch@lst.de, martin@omnibond.com Subject: [PATCH 0/2] aio: intialize kiocb private Date: Tue, 5 Feb 2019 14:13:33 -0500 Message-Id: <20190205191335.22056-1-hubcap@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org From: Mike Marshall "aio: don't zero entire aio_kiocb aio_get_req" triggered these BUG_ONs in orangefs file.c. Obviously the BUG_ONs need to go. There might be other filesystems that use iocb->private without failing in a way that is as obvious as BUG_ON, though I didn't see any with grep. After discussion on fsdevel, Jens Axboe suggested I should send in a patch that continues to set iocb->private to NULL just in case. Also... phooey on fighting gmail when trying to send patches with git-send-email... mail.kernel.org works great! -Mike