From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B3EAC169C4 for ; Wed, 6 Feb 2019 09:50:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 116E820B1F for ; Wed, 6 Feb 2019 09:50:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728328AbfBFJuZ (ORCPT ); Wed, 6 Feb 2019 04:50:25 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:36070 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727953AbfBFJuZ (ORCPT ); Wed, 6 Feb 2019 04:50:25 -0500 Received: by mail-wr1-f68.google.com with SMTP id z3so6797706wrv.3 for ; Wed, 06 Feb 2019 01:50:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=x/TBpMr4A+gzw/rgiRCkXWKXDYdbbsq4/knjrkCh/D4=; b=Kead33guDZBIaKM42lCn0sLLbRa4yNn31RW0uh8/ygErn7kk60/ZY+Hph2soMe5Xew tmEf7jmK2IX65l75WKVMr2wya306rdNrniNE+kF31EuiDEuUT8GXdf1MULfgY6MY0MDY 2/FsJHeGPWyMPDrbUCOZBwHLbIROz5baH3Jt3F+adifg97f740L2QpHaFZDvtY9YHpJY 4t5wnZPRUU+Qdw64EVO2IzgUc8Y9v08e6AdNh4Vi92n1xTn89Tl0+JzCVlADBDa6iagM XgKycd695QLncp50qCUqp0ue9MPTuMP0H7YarR7xXCGIeWlsOE7AvG3sima5dkJj7xbb 60Mg== X-Gm-Message-State: AHQUAuZ2opQWVAgk1tguqjB/1jhVW8vvIjoeceoWNMYBu4NylL3Em+GR aMOXkbL/XY0lRc9dbynEQQtzuRhRX1w= X-Google-Smtp-Source: AHgI3IbvnRDfmWPe6Cb8S0YFc5HFVNk3n6DyhhzmF35hUKwdr74vxDVJ/9jiORrvtBvg1WYJne6qlA== X-Received: by 2002:a5d:60cc:: with SMTP id x12mr6882431wrt.193.1549446623505; Wed, 06 Feb 2019 01:50:23 -0800 (PST) Received: from hades.usersys.redhat.com (ip-89-103-126-188.net.upcbroadband.cz. [89.103.126.188]) by smtp.gmail.com with ESMTPSA id e9sm22023542wro.16.2019.02.06.01.50.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Feb 2019 01:50:22 -0800 (PST) Date: Wed, 6 Feb 2019 10:50:20 +0100 From: Carlos Maiolino To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, adilger@dilger.ca, sandeen@redhat.com, david@fromorbit.com Subject: Re: [PATCH 09/10 V2] Use FIEMAP for FIBMAP calls Message-ID: <20190206095020.mizodx5erp3ilhxp@hades.usersys.redhat.com> References: <20181205091728.29903-1-cmaiolino@redhat.com> <20181205091728.29903-10-cmaiolino@redhat.com> <20190114165617.GG7187@lst.de> <20190205095601.drsskdfzbpul2zh2@hades.usersys.redhat.com> <20190205182518.GB3302@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190205182518.GB3302@lst.de> User-Agent: NeoMutt/20180716 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Feb 05, 2019 at 07:25:18PM +0100, Christoph Hellwig wrote: > On Tue, Feb 05, 2019 at 10:56:01AM +0100, Carlos Maiolino wrote: > > > Any reason this function isn't in inode.c next to the caller and marked > > > static? > > > > > > > No reason other than to keep it close to its peer fiemap_fill_user_extent(), I > > honestly do prefer to keep both together than in separated files. But, I'm up > > to move it to fs/inode.c if required. > > After your series fiemap_fill_user_extent should be static and close > to it's caller, so with the kernel one in inode.c everything should > be neat and symmetric. You are right, I didn't pay attention to that, thanks for the heads up, I'll fix it on the next version -- Carlos