* [PATCH RESEND] fs/read_write.c: make __vfs_write() static
@ 2019-01-10 20:41 Eric Biggers
2019-02-07 23:39 ` Eric Biggers
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2019-01-10 20:41 UTC (permalink / raw)
To: linux-fsdevel, Alexander Viro
From: Eric Biggers <ebiggers@google.com>
__vfs_write() is only used in fs/read_write.c, so make it static.
This addresses a gcc warning when -Wmissing-prototypes is enabled.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/read_write.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/read_write.c b/fs/read_write.c
index ff3c5e6f87cfa..4b328e45db366 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -478,8 +478,8 @@ static ssize_t new_sync_write(struct file *filp, const char __user *buf, size_t
return ret;
}
-ssize_t __vfs_write(struct file *file, const char __user *p, size_t count,
- loff_t *pos)
+static ssize_t __vfs_write(struct file *file, const char __user *p,
+ size_t count, loff_t *pos)
{
if (file->f_op->write)
return file->f_op->write(file, p, count, pos);
--
2.20.1.97.g81188d93c3-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] fs/read_write.c: make __vfs_write() static
2019-01-10 20:41 [PATCH RESEND] fs/read_write.c: make __vfs_write() static Eric Biggers
@ 2019-02-07 23:39 ` Eric Biggers
0 siblings, 0 replies; 2+ messages in thread
From: Eric Biggers @ 2019-02-07 23:39 UTC (permalink / raw)
To: linux-fsdevel, Alexander Viro
On Thu, Jan 10, 2019 at 12:41:53PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> __vfs_write() is only used in fs/read_write.c, so make it static.
>
> This addresses a gcc warning when -Wmissing-prototypes is enabled.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/read_write.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/read_write.c b/fs/read_write.c
> index ff3c5e6f87cfa..4b328e45db366 100644
> --- a/fs/read_write.c
> +++ b/fs/read_write.c
> @@ -478,8 +478,8 @@ static ssize_t new_sync_write(struct file *filp, const char __user *buf, size_t
> return ret;
> }
>
> -ssize_t __vfs_write(struct file *file, const char __user *p, size_t count,
> - loff_t *pos)
> +static ssize_t __vfs_write(struct file *file, const char __user *p,
> + size_t count, loff_t *pos)
> {
> if (file->f_op->write)
> return file->f_op->write(file, p, count, pos);
> --
> 2.20.1.97.g81188d93c3-goog
>
Ping. Al, are you planning to apply this?
- Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-07 23:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 20:41 [PATCH RESEND] fs/read_write.c: make __vfs_write() static Eric Biggers
2019-02-07 23:39 ` Eric Biggers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).