From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=EfYg=QO=vger.kernel.org=linux-fsdevel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,INCLUDES_PATCH,MAILING_LIST_MULTI,
	SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 6D5C2C282C2
	for <linux-fsdevel@archiver.kernel.org>; Thu,  7 Feb 2019 23:39:26 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 254B021721
	for <linux-fsdevel@archiver.kernel.org>; Thu,  7 Feb 2019 23:39:26 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1549582766;
	bh=Qy73G9wE0TafQGNQm61OCHRfrskr/k1r+XeGLcdJE0c=;
	h=Date:From:To:Subject:References:In-Reply-To:List-ID:From;
	b=x2Hw/5ps8stVc60A/hKFMVibnffueQqpfxLM295yYJPcHGJr5wg21mJXlna/U0v+y
	 Xy14bcqt2V3onZTNfNGaYZ2Wg2Ffbx42S/S9W2zYSmuC/DUwVGYofdJuoqj1R/132g
	 FkA9FM/s2IC2QsbXlq6/nCinWr3EsyoBDr4UvBEc=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726718AbfBGXjZ (ORCPT
        <rfc822;linux-fsdevel@archiver.kernel.org>);
        Thu, 7 Feb 2019 18:39:25 -0500
Received: from mail.kernel.org ([198.145.29.99]:52752 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726622AbfBGXjZ (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Thu, 7 Feb 2019 18:39:25 -0500
Received: from gmail.com (unknown [104.132.1.77])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id B9FBF2085A;
        Thu,  7 Feb 2019 23:39:24 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1549582764;
        bh=Qy73G9wE0TafQGNQm61OCHRfrskr/k1r+XeGLcdJE0c=;
        h=Date:From:To:Subject:References:In-Reply-To:From;
        b=jUhm6l2rJXiRgc8PS8lJ1somzuaKSZwt7xYnrgM4aTpXCOCO+8BhmwPoYDU5HCD2a
         HLePlEETGUDMKNfj+Snyf5z0rHEhHWAbmzjRymchfx8u7JB+VJ2HoDPcANQB8bnuiw
         rw16jNnCGJfGkANA3ETXLXRxSXjSNnJ7W9WCTP5s=
Date:   Thu, 7 Feb 2019 15:39:23 -0800
From:   Eric Biggers <ebiggers@kernel.org>
To:     linux-fsdevel@vger.kernel.org,
        Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH RESEND] fs/nsfs.c: include linux/proc_fs.h for
 open_related_ns()
Message-ID: <20190207233922.GG125156@gmail.com>
References: <20190110204150.120124-1-ebiggers@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190110204150.120124-1-ebiggers@kernel.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-fsdevel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-fsdevel.vger.kernel.org>
X-Mailing-List: linux-fsdevel@vger.kernel.org

On Thu, Jan 10, 2019 at 12:41:50PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> open_related_ns() is defined in fs/nsfs.c and declared in
> linux/proc_fs.h, but the declaration isn't included at the point of the
> definition.  Include the header to enforce that the definition matches
> the declaration.
> 
> This addresses a gcc warning when -Wmissing-prototypes is enabled.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  fs/nsfs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/nsfs.c b/fs/nsfs.c
> index 60702d677bd4e..a7ff518400a10 100644
> --- a/fs/nsfs.c
> +++ b/fs/nsfs.c
> @@ -2,6 +2,7 @@
>  #include <linux/mount.h>
>  #include <linux/file.h>
>  #include <linux/fs.h>
> +#include <linux/proc_fs.h>
>  #include <linux/proc_ns.h>
>  #include <linux/magic.h>
>  #include <linux/ktime.h>
> -- 
> 2.20.1.97.g81188d93c3-goog
> 

Ping.  Al, are you planning to apply this?

- Eric