From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9E11C282C2 for ; Thu, 7 Feb 2019 23:39:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F6B121721 for ; Thu, 7 Feb 2019 23:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549582783; bh=qAHJ3d81+PPCqmLZnUlTaOSwk/oXoKJ/ewbHU+9E/9g=; h=Date:From:To:Subject:References:In-Reply-To:List-ID:From; b=ZVWvBT+JPds9x2SX246gE4zkaInK8TwWOcZ5LEXmGHNhq6gQBZj2GGN5CMtWAvjkd Q5X6ocRQpMSQzEg+OnpBfK/A7eI1oaVscgUNkdtrEhyHuRG4PAJLl2ERc7+idw6g4Q O616vp0sbYLKL9wgHm0LnIQ1dGmjnM53z+Ws6Nnk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726764AbfBGXjn (ORCPT ); Thu, 7 Feb 2019 18:39:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:53140 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726731AbfBGXjm (ORCPT ); Thu, 7 Feb 2019 18:39:42 -0500 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C0442085A; Thu, 7 Feb 2019 23:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549582782; bh=qAHJ3d81+PPCqmLZnUlTaOSwk/oXoKJ/ewbHU+9E/9g=; h=Date:From:To:Subject:References:In-Reply-To:From; b=11DEOFwSvQDFVPgUKTTLgT9Eup5s7AmqsB9pZJ1ByAn59QLVXo4u8B362sjm7R44L uOloSDavp/S5D8NWKJpStsNdkbMEInICbpeITeD7IQpOmrz5znmDl94oiUY1oAtGUK kV/f0cQq2Ks128zuVc2pcUUnOaO6Q8GLMAI4qv18= Date: Thu, 7 Feb 2019 15:39:41 -0800 From: Eric Biggers To: linux-fsdevel@vger.kernel.org, Alexander Viro Subject: Re: [PATCH RESEND] fs/namespace.c: make to_mnt_ns() static Message-ID: <20190207233940.GH125156@gmail.com> References: <20190110204147.120073-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190110204147.120073-1-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jan 10, 2019 at 12:41:47PM -0800, Eric Biggers wrote: > From: Eric Biggers > > to_mnt_ns() is only used in fs/namespace.c, so make it static. > > This addresses a gcc warning when -Wmissing-prototypes is enabled. > > Signed-off-by: Eric Biggers > --- > fs/namespace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/namespace.c b/fs/namespace.c > index a677b59efd74e..2ba0dbd8573a2 100644 > --- a/fs/namespace.c > +++ b/fs/namespace.c > @@ -1688,7 +1688,7 @@ static bool is_mnt_ns_file(struct dentry *dentry) > dentry->d_fsdata == &mntns_operations; > } > > -struct mnt_namespace *to_mnt_ns(struct ns_common *ns) > +static struct mnt_namespace *to_mnt_ns(struct ns_common *ns) > { > return container_of(ns, struct mnt_namespace, ns); > } > -- > 2.20.1.97.g81188d93c3-goog > Ping. Al, are you planning to apply this? - Eric