Linux-Fsdevel Archive on lore.kernel.org
 help / Atom feed
* [PATCH RESEND] fs/buffer.c: include fs/internal.h for missing prototypes
@ 2019-01-10 20:40 Eric Biggers
  2019-02-07 23:40 ` Eric Biggers
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2019-01-10 20:40 UTC (permalink / raw)
  To: linux-fsdevel, Alexander Viro

From: Eric Biggers <ebiggers@google.com>

__block_write_begin_int(), __generic_write_end(), and guard_bio_eod()
are defined in fs/buffer.c and declared in fs/internal.h, but the
declarations aren't included at the point of the definitions.  Include
the header to enforce that the definitions match the declarations.

This addresses gcc warnings when -Wmissing-prototypes is enabled.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 fs/buffer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/buffer.c b/fs/buffer.c
index 52d024bfdbc12..7a9937b0cb9f3 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -46,6 +46,7 @@
 #include <linux/pagevec.h>
 #include <linux/sched/mm.h>
 #include <trace/events/block.h>
+#include "internal.h"
 
 static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
 static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
-- 
2.20.1.97.g81188d93c3-goog


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH RESEND] fs/buffer.c: include fs/internal.h for missing prototypes
  2019-01-10 20:40 [PATCH RESEND] fs/buffer.c: include fs/internal.h for missing prototypes Eric Biggers
@ 2019-02-07 23:40 ` Eric Biggers
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Biggers @ 2019-02-07 23:40 UTC (permalink / raw)
  To: linux-fsdevel, Alexander Viro

On Thu, Jan 10, 2019 at 12:40:41PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> __block_write_begin_int(), __generic_write_end(), and guard_bio_eod()
> are defined in fs/buffer.c and declared in fs/internal.h, but the
> declarations aren't included at the point of the definitions.  Include
> the header to enforce that the definitions match the declarations.
> 
> This addresses gcc warnings when -Wmissing-prototypes is enabled.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  fs/buffer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 52d024bfdbc12..7a9937b0cb9f3 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -46,6 +46,7 @@
>  #include <linux/pagevec.h>
>  #include <linux/sched/mm.h>
>  #include <trace/events/block.h>
> +#include "internal.h"
>  
>  static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
>  static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
> -- 
> 2.20.1.97.g81188d93c3-goog
> 

Ping.  Al, are you planning to apply this?

- Eric

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 20:40 [PATCH RESEND] fs/buffer.c: include fs/internal.h for missing prototypes Eric Biggers
2019-02-07 23:40 ` Eric Biggers

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org linux-fsdevel@archiver.kernel.org
	public-inbox-index linux-fsdevel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox