From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F7EC282C2 for ; Thu, 7 Feb 2019 23:40:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E52221721 for ; Thu, 7 Feb 2019 23:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549582805; bh=84HWwDBa5V0bR66EZfwoNK6DM2VjsHeDsIKbcNn5TuQ=; h=Date:From:To:Subject:References:In-Reply-To:List-ID:From; b=jAr/Ft+DwN7vrvDxVNUZiXBE478IK0hLBosdcNK1sVlOd5V3zMi2CXl8x77dm4V0s M6YaZx1yj4vzxoPWQeQ1K8b2R04sIu+j0YN2yZZ0Qd1bNglC/d6oCjFsU32fR0ZA5S UoHfB2WkyeXA+vL3D1utnFH3Vp9oNR65/qgAfXe4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726799AbfBGXkE (ORCPT ); Thu, 7 Feb 2019 18:40:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:53678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726401AbfBGXkE (ORCPT ); Thu, 7 Feb 2019 18:40:04 -0500 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 38C842085A; Thu, 7 Feb 2019 23:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549582804; bh=84HWwDBa5V0bR66EZfwoNK6DM2VjsHeDsIKbcNn5TuQ=; h=Date:From:To:Subject:References:In-Reply-To:From; b=jEYSymUnV6IMPt/fPyD0yhFrukbzNibYUGTEk3xezk9/WWXSlPw0gdDz4IogD61Qo 1JvOO8dldEtzVM5Y0HHd26WqNWBWApEkSKUpHXyGnaIBHJ0lmeI1RWcdTuyHG8IH3l Dg/04tAfKZxKVfDLcie4ac1jGA7YJ2Q/Jaq03fjk= Date: Thu, 7 Feb 2019 15:40:02 -0800 From: Eric Biggers To: linux-fsdevel@vger.kernel.org, Alexander Viro Subject: Re: [PATCH RESEND] fs/buffer.c: include fs/internal.h for missing prototypes Message-ID: <20190207234002.GJ125156@gmail.com> References: <20190110204041.119841-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190110204041.119841-1-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jan 10, 2019 at 12:40:41PM -0800, Eric Biggers wrote: > From: Eric Biggers > > __block_write_begin_int(), __generic_write_end(), and guard_bio_eod() > are defined in fs/buffer.c and declared in fs/internal.h, but the > declarations aren't included at the point of the definitions. Include > the header to enforce that the definitions match the declarations. > > This addresses gcc warnings when -Wmissing-prototypes is enabled. > > Signed-off-by: Eric Biggers > --- > fs/buffer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/buffer.c b/fs/buffer.c > index 52d024bfdbc12..7a9937b0cb9f3 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -46,6 +46,7 @@ > #include > #include > #include > +#include "internal.h" > > static int fsync_buffers_list(spinlock_t *lock, struct list_head *list); > static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh, > -- > 2.20.1.97.g81188d93c3-goog > Ping. Al, are you planning to apply this? - Eric