* [PATCH RESEND] fs/buffer.c: include fs/internal.h for missing prototypes
@ 2019-01-10 20:40 Eric Biggers
2019-02-07 23:40 ` Eric Biggers
0 siblings, 1 reply; 3+ messages in thread
From: Eric Biggers @ 2019-01-10 20:40 UTC (permalink / raw)
To: linux-fsdevel, Alexander Viro
From: Eric Biggers <ebiggers@google.com>
__block_write_begin_int(), __generic_write_end(), and guard_bio_eod()
are defined in fs/buffer.c and declared in fs/internal.h, but the
declarations aren't included at the point of the definitions. Include
the header to enforce that the definitions match the declarations.
This addresses gcc warnings when -Wmissing-prototypes is enabled.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/buffer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/buffer.c b/fs/buffer.c
index 52d024bfdbc12..7a9937b0cb9f3 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -46,6 +46,7 @@
#include <linux/pagevec.h>
#include <linux/sched/mm.h>
#include <trace/events/block.h>
+#include "internal.h"
static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
--
2.20.1.97.g81188d93c3-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] fs/buffer.c: include fs/internal.h for missing prototypes
2019-01-10 20:40 [PATCH RESEND] fs/buffer.c: include fs/internal.h for missing prototypes Eric Biggers
@ 2019-02-07 23:40 ` Eric Biggers
0 siblings, 0 replies; 3+ messages in thread
From: Eric Biggers @ 2019-02-07 23:40 UTC (permalink / raw)
To: linux-fsdevel, Alexander Viro
On Thu, Jan 10, 2019 at 12:40:41PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> __block_write_begin_int(), __generic_write_end(), and guard_bio_eod()
> are defined in fs/buffer.c and declared in fs/internal.h, but the
> declarations aren't included at the point of the definitions. Include
> the header to enforce that the definitions match the declarations.
>
> This addresses gcc warnings when -Wmissing-prototypes is enabled.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/buffer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 52d024bfdbc12..7a9937b0cb9f3 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -46,6 +46,7 @@
> #include <linux/pagevec.h>
> #include <linux/sched/mm.h>
> #include <trace/events/block.h>
> +#include "internal.h"
>
> static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
> static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
> --
> 2.20.1.97.g81188d93c3-goog
>
Ping. Al, are you planning to apply this?
- Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH RESEND] fs/buffer.c: include fs/internal.h for missing prototypes
@ 2019-08-22 15:39 Eric Biggers
0 siblings, 0 replies; 3+ messages in thread
From: Eric Biggers @ 2019-08-22 15:39 UTC (permalink / raw)
To: Alexander Viro, linux-fsdevel
From: Eric Biggers <ebiggers@google.com>
Include fs/internal.h to address the following 'sparse' warnings:
fs/buffer.c:1930:5: warning: symbol '__block_write_begin_int' was not declared. Should it be static?
fs/buffer.c:2089:6: warning: symbol '__generic_write_end' was not declared. Should it be static?
fs/buffer.c:2998:6: warning: symbol 'guard_bio_eod' was not declared. Should it be static?
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/buffer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/buffer.c b/fs/buffer.c
index 0faa41fb4c88..95d08807863b 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -47,6 +47,8 @@
#include <linux/sched/mm.h>
#include <trace/events/block.h>
+#include "internal.h"
+
static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
enum rw_hint hint, struct writeback_control *wbc);
--
2.22.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-22 15:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 20:40 [PATCH RESEND] fs/buffer.c: include fs/internal.h for missing prototypes Eric Biggers
2019-02-07 23:40 ` Eric Biggers
2019-08-22 15:39 Eric Biggers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).