From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 708CEC169C4 for ; Mon, 11 Feb 2019 16:21:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44C15218F0 for ; Mon, 11 Feb 2019 16:21:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727844AbfBKQVp (ORCPT ); Mon, 11 Feb 2019 11:21:45 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:35451 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726941AbfBKQVp (ORCPT ); Mon, 11 Feb 2019 11:21:45 -0500 Received: by mail-wr1-f67.google.com with SMTP id t18so1036632wrx.2 for ; Mon, 11 Feb 2019 08:21:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oHi8TzSgJWb8+zEljjLrGZrelkWOYlKES8R2opyjw7E=; b=rBeLLMhGR9yLVTl5r22fHuQ7NTLJO24ZeUTtCSaO7j6ypCnRtOrZnLvBTGndFqjPkG z4DZ46h0j1I61RymX7TXfzc5YjZAb7g6jOzcZC30FptCvlTXXVAiAxsUaIYd90OdgRji +XiDLZTgvoSxUIz9BljFRL6dWKni8vZ49iN5aCXGSznEK2jLT5R7vxL79wgm1n53g+PW IramOcG0dQRiYhCc2weLy6gZG/1gtEoZf1AIdEhk9+5/GODSiLTz48TXaf0zqmSXnGVP VtTvWKkl/+iSZP2GY0pLUxxv1mnMmPLpg7EDNWolUDMslt2sTEUc3PcpEV3zccZ4XoJc ToMQ== X-Gm-Message-State: AHQUAuafDYVMpRKa8ZCvNu8JYXZbZeVRiy+RCAF3mi8jDlD9uKY8LT3Z zWubedIyLlXH6NvL/UEhZRYWww== X-Google-Smtp-Source: AHgI3IYZzryV2U+pZyzw7+inisVTWhvfFzRNDy5qyLidd4lGqtDZ4WzXRAQvKmM7WLQ9UFr7jFWhBA== X-Received: by 2002:a05:6000:6:: with SMTP id h6mr27244595wrx.68.1549902103511; Mon, 11 Feb 2019 08:21:43 -0800 (PST) Received: from hades.usersys.redhat.com (ip-89-103-126-188.net.upcbroadband.cz. [89.103.126.188]) by smtp.gmail.com with ESMTPSA id g11sm2722817wmk.26.2019.02.11.08.21.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 08:21:42 -0800 (PST) Date: Mon, 11 Feb 2019 17:21:40 +0100 From: Carlos Maiolino To: Christoph Hellwig Cc: Andreas Dilger , "Darrick J. Wong" , linux-fsdevel , Eric Sandeen , david@fromorbit.com Subject: Re: [PATCH 09/10 V2] Use FIEMAP for FIBMAP calls Message-ID: <20190211162140.2phecn37257e3f6y@hades.usersys.redhat.com> References: <20181205091728.29903-10-cmaiolino@redhat.com> <20181205173650.GA8112@magnolia> <20190204151147.rra4n7k56ec4ndob@hades.usersys.redhat.com> <20190204182722.GA32119@magnolia> <20190206133753.oqpw7citye6apdpr@hades.usersys.redhat.com> <20190206204431.GB32119@magnolia> <0258844F-A305-4744-8C70-B27A3E49ADEC@dilger.ca> <20190207095233.imqha36zgoqilxx2@hades.usersys.redhat.com> <20190208084352.GA23194@lst.de> <20190211125708.GA21583@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190211125708.GA21583@lst.de> User-Agent: NeoMutt/20180716 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Feb 11, 2019 at 01:57:08PM +0100, Christoph Hellwig wrote: > On Fri, Feb 08, 2019 at 09:43:52AM +0100, Christoph Hellwig wrote: > > Agreed. Please don't change the FIEMAP uapi. If we need to check > > for a request coming from bmap just defined an internal FIEMAP flag > > as the last available flag in the flags word, and reject it when > > it comes from userspace in fiemap. > > Based on the new thread you started it seems like this go lost. I think > we are 99% done with the bmap through fiemap series, and it is just > missing this internal flag to make progress. Let's finish this off > before starting another big project in the area. I'm more than happy in see your reply, I'd love to finish this, but I got stuck in how to make some filesystems deny a FIBMAP call once they do support FIEMAP but not FIBMAP. I have this patch almost ready to go anyway. Do you agree in keep this flag in fi_flags field? Or maybe some other place, dunno, maybe a new fi_private field. > -- Carlos