Linux-Fsdevel Archive on lore.kernel.org
 help / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Slavomir Kaslev <kaslevs@vmware.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	Jens Axboe <axboe@kernel.dk>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes
Date: Wed, 13 Feb 2019 09:44:45 -0500
Message-ID: <20190213094445.1774f959@gandalf.local.home> (raw)
In-Reply-To: <20190207154519.8635-1-kaslevs@vmware.com>

On Thu,  7 Feb 2019 17:45:19 +0200
Slavomir Kaslev <kaslevs@vmware.com> wrote:

> The current implementation of splice() and tee() ignores O_NONBLOCK set on pipe
> file descriptors and checks only the SPLICE_F_NONBLOCK flag for blocking on pipe
> arguments. This is inconsistent since splice()-ing from/to non-pipe file
> descriptors does take O_NONBLOCK into consideration.
> 
> Fix this by promoting O_NONBLOCK, when set on a pipe, to SPLICE_F_NONBLOCK.
> 
> Some context for how the current implementation of splice() leads to
> inconsistent behavior. In the ongoing work[1] to add VM tracing capability to
> trace-cmd we stream tracing data over named FIFOs or vsockets from guests back
> to the host.
> 
> When we receive SIGINT from user to stop tracing, we set O_NONBLOCK on the input
> file descriptor and set SPLICE_F_NONBLOCK for the next call to splice(). If
> splice() was blocked waiting on data from the input FIFO, after SIGINT splice()
> restarts with the same arguments (no SPLICE_F_NONBLOCK) and blocks again instead
> of returning -EAGAIN when no data is available.
> 
> This differs from the splice() behavior when reading from a vsocket or when
> we're doing a traditional read()/write() loop (trace-cmd's --nosplice argument).
> 
> With this patch applied we get the same behavior in all situations after setting
> O_NONBLOCK which also matches the behavior of doing a read()/write() loop
> instead of splice().
> 
> This change does have potential of breaking users who don't expect EAGAIN from
> splice() when SPLICE_F_NONBLOCK is not set. OTOH programs that set O_NONBLOCK
> and don't anticipate EAGAIN are arguably buggy[2].

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Does anyone have any issues or comments about this patch?

Thanks!

-- Steve

> 
> [1] https://github.com/skaslev/trace-cmd/tree/vsock
> [2] https://github.com/torvalds/linux/blob/d47e3da1759230e394096fd742aad423c291ba48/fs/read_write.c#L1425
> 
> Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
> ---
>  fs/splice.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/fs/splice.c b/fs/splice.c
> index de2ede048473..6a1761b74f8d 100644
> --- a/fs/splice.c
> +++ b/fs/splice.c
> @@ -1123,6 +1123,9 @@ static long do_splice(struct file *in, loff_t __user *off_in,
>  		if (ipipe == opipe)
>  			return -EINVAL;
>  
> +		if ((in->f_flags | out->f_flags) & O_NONBLOCK)
> +			flags |= SPLICE_F_NONBLOCK;
> +
>  		return splice_pipe_to_pipe(ipipe, opipe, len, flags);
>  	}
>  
> @@ -1148,6 +1151,9 @@ static long do_splice(struct file *in, loff_t __user *off_in,
>  		if (unlikely(ret < 0))
>  			return ret;
>  
> +		if (in->f_flags & O_NONBLOCK)
> +			flags |= SPLICE_F_NONBLOCK;
> +
>  		file_start_write(out);
>  		ret = do_splice_from(ipipe, out, &offset, len, flags);
>  		file_end_write(out);
> @@ -1172,6 +1178,9 @@ static long do_splice(struct file *in, loff_t __user *off_in,
>  			offset = in->f_pos;
>  		}
>  
> +		if (out->f_flags & O_NONBLOCK)
> +			flags |= SPLICE_F_NONBLOCK;
> +
>  		pipe_lock(opipe);
>  		ret = wait_for_space(opipe, flags);
>  		if (!ret)
> @@ -1717,6 +1726,9 @@ static long do_tee(struct file *in, struct file *out, size_t len,
>  	 * copying the data.
>  	 */
>  	if (ipipe && opipe && ipipe != opipe) {
> +		if ((in->f_flags | out->f_flags) & O_NONBLOCK)
> +			flags |= SPLICE_F_NONBLOCK;
> +
>  		/*
>  		 * Keep going, unless we encounter an error. The ipipe/opipe
>  		 * ordering doesn't really matter.


  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07 15:45 Slavomir Kaslev
2019-02-13 14:44 ` Steven Rostedt [this message]
2019-02-19 17:12   ` Steven Rostedt
2019-03-04 15:58     ` Steven Rostedt
2019-03-05  0:04       ` Linus Torvalds
2019-03-05  0:09         ` Linus Torvalds
2019-03-05  1:54           ` Steven Rostedt

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190213094445.1774f959@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=axboe@kernel.dk \
    --cc=kaslevs@vmware.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org linux-fsdevel@archiver.kernel.org
	public-inbox-index linux-fsdevel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox