linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Czerner <lczerner@redhat.com>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: lsf-pc@lists.linux-foundation.org, linux-block@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [LSF/MM TOPIC] improving storage testing
Date: Thu, 14 Feb 2019 13:10:40 +0100	[thread overview]
Message-ID: <20190214121040.vckivyo5qcp6iyc4@localhost.localdomain> (raw)
In-Reply-To: <20190213180754.GX23000@mit.edu>

On Wed, Feb 13, 2019 at 01:07:54PM -0500, Theodore Y. Ts'o wrote:
> 
> 2) Documenting what are known failures should be for various tests on
> different file systems and kernel versions.  I think we all have our
> own way of excluding tests which are known to fail.  One extreme case
> is where the test case was added to xfstests (generic/484), but the
> patch to fix it got hung up because it was somewhat controversial, so
> it was failing on all file systems.
> 
> Other cases might be when fixing a particular test failure is too
> complex to backport to stable (maybe because it would drag in all
> sorts of other changes in other subsystems), so that test is Just
> Going To Fail for a particular stable kernel series.
> 
> It probably doesn't make sense to do this in xfstests, which is why we
> all have our own individual test runners that are layered on top of
> xfstests.  But if we want to automate running xfstests for stable
> kernel series, some way of annotating fixes for different kernel
> versions would be useful, perhaps some kind of centralized clearing
> house of this information would be useful.

I think that the first step can be to require the new test to go in
"after" the respective kernel fix. And related to that, require the test
to include a well-defined tag (preferably both in the test itself and
commit description) saying which commit fixed this particular problem.

It does not solve all the problems, but would be a huge help. We could
also update old tests regularly with new tags as problems are introduced
and fixed, but that's a bit more involved. One thing that would help
with this would be to tag a kernel commit that fixes a problem for which
we already have a tast with the repeoctive test number.


Another think I was planning to do since forever was to create a
standard machine readble output, the ability to construct a database of
the results and present it in the easily browsable format like a set of
html with help of js. I never got around to it, but it would be nice to
be able to compare historical data, kernel versions, options, or even
file systems and identify tests that often fail, or never fail and even
how the run time differs. That might also help one to construct fast,
quick fail set of tests from ones own historical data. It would open some
interesting possibilities.

-Lukas

  parent reply	other threads:[~2019-02-14 12:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 18:07 [LSF/MM TOPIC] improving storage testing Theodore Y. Ts'o
2019-02-14  7:37 ` Chaitanya Kulkarni
2019-02-14 10:55 ` Johannes Thumshirn
2019-02-14 16:21   ` David Sterba
2019-02-14 23:26   ` Bart Van Assche
2019-02-15  2:52     ` Chaitanya Kulkarni
2019-02-15  7:52       ` Johannes Thumshirn
2019-02-14 12:10 ` Lukas Czerner [this message]
2019-02-14 21:28   ` Omar Sandoval
2019-02-14 21:56 ` Omar Sandoval
2019-02-15  3:02   ` Theodore Y. Ts'o
2019-02-15 17:32     ` Keith Busch
2019-02-20  1:33       ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190214121040.vckivyo5qcp6iyc4@localhost.localdomain \
    --to=lczerner@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=lsf-pc@lists.linux-foundation.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).