From: Al Viro <viro@zeniv.linux.org.uk>
To: YueHaibing <yuehaibing@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
dmitry.kasatkin@huawei.com, keescook@chromium.org
Subject: Re: [PATCH -next] exec: Fix mem leak in kernel_read_file
Date: Tue, 19 Feb 2019 02:25:12 +0000 [thread overview]
Message-ID: <20190219022512.GW2217@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20190219021038.11340-1-yuehaibing@huawei.com>
On Tue, Feb 19, 2019 at 10:10:38AM +0800, YueHaibing wrote:
> syzkaller report this:
> BUG: memory leak
> unreferenced object 0xffffc9000488d000 (size 9195520):
> comm "syz-executor.0", pid 2752, jiffies 4294787496 (age 18.757s)
> hex dump (first 32 bytes):
> ff ff ff ff ff ff ff ff a8 00 00 00 01 00 00 00 ................
> 02 00 00 00 00 00 00 00 80 a1 7a c1 ff ff ff ff ..........z.....
> backtrace:
> [<000000000863775c>] __vmalloc_node mm/vmalloc.c:1795 [inline]
> [<000000000863775c>] __vmalloc_node_flags mm/vmalloc.c:1809 [inline]
> [<000000000863775c>] vmalloc+0x8c/0xb0 mm/vmalloc.c:1831
> [<000000003f668111>] kernel_read_file+0x58f/0x7d0 fs/exec.c:924
> [<000000002385813f>] kernel_read_file_from_fd+0x49/0x80 fs/exec.c:993
> [<0000000011953ff1>] __do_sys_finit_module+0x13b/0x2a0 kernel/module.c:3895
> [<000000006f58491f>] do_syscall_64+0x147/0x600 arch/x86/entry/common.c:290
> [<00000000ee78baf4>] entry_SYSCALL_64_after_hwframe+0x49/0xbe
> [<00000000241f889b>] 0xffffffffffffffff
>
> It should goto 'out_free' lable to free allocated buf while kernel_read
> fails.
Applied.
next prev parent reply other threads:[~2019-02-19 2:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 2:10 [PATCH -next] exec: Fix mem leak in kernel_read_file YueHaibing
2019-02-19 2:25 ` Al Viro [this message]
2019-03-11 16:59 ` Dmitry Kasatkin
2019-03-11 23:16 ` Sasha Levin
2019-03-13 14:12 ` Dmitry Kasatkin
2019-03-13 14:38 ` gregkh
2019-03-13 15:00 ` Dmitry Kasatkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219022512.GW2217@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dmitry.kasatkin@huawei.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).