From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5893C10F00 for ; Wed, 20 Feb 2019 02:07:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C5902146F for ; Wed, 20 Feb 2019 02:07:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726544AbfBTCHd (ORCPT ); Tue, 19 Feb 2019 21:07:33 -0500 Received: from fieldses.org ([173.255.197.46]:47892 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726235AbfBTCHd (ORCPT ); Tue, 19 Feb 2019 21:07:33 -0500 Received: by fieldses.org (Postfix, from userid 2815) id 8C11A88A; Tue, 19 Feb 2019 21:07:32 -0500 (EST) Date: Tue, 19 Feb 2019 21:07:32 -0500 To: Olga Kornievskaia Cc: bfields@redhat.com, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 06/10] NFSD add COPY_NOTIFY operation Message-ID: <20190220020732.GF19603@fieldses.org> References: <20181130200348.59524-1-olga.kornievskaia@gmail.com> <20181130200348.59524-7-olga.kornievskaia@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181130200348.59524-7-olga.kornievskaia@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) From: bfields@fieldses.org (J. Bruce Fields) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Nov 30, 2018 at 03:03:44PM -0500, Olga Kornievskaia wrote: > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c > index 879ddc6..c9fb625 100644 > --- a/fs/nfsd/nfs4xdr.c > +++ b/fs/nfsd/nfs4xdr.c ... > + /* cnr_lease_time */ > + p = xdr_encode_hyper(p, cn->cpn_sec); > + *p++ = cpu_to_be32(cn->cpn_nsec); This is redundant; xdr_encode_hyper already wrote cn->cpn_sec. --b.