From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: <linux-fsdevel@vger.kernel.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
<linux-ext4@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext4: add sysfs attr /sys/fs/ext4/<disk>/journal_task
Date: Thu, 21 Feb 2019 11:52:58 -0500 [thread overview]
Message-ID: <20190221165258.GE10245@mit.edu> (raw)
In-Reply-To: <154927546304.133377.2385004506198637025.stgit@buzz>
On Mon, Feb 04, 2019 at 01:17:43PM +0300, Konstantin Khlebnikov wrote:
> This is useful for moving journal thread into cgroup or
> for tracing it with ftrace/perf/blktrace.
>
> For now the only way is `pgrep jbd2/$DISK` but this is not reliable:
> name may be longer than "comm" limit and any task could mock it.
>
> Attribute shows pid in current pid-namespace or 0 if task is unreachable.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Thanks, applied with one change; if the file system does not have a
journal, reading the /sys/fs/ext4/<disk>/journal_task will return
"<none>" instead of returning a ESRCH error.
- Ted
prev parent reply other threads:[~2019-02-21 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 10:17 [PATCH] ext4: add sysfs attr /sys/fs/ext4/<disk>/journal_task Konstantin Khlebnikov
2019-02-21 16:52 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221165258.GE10245@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).