From: Karel Zak <kzak@redhat.com>
To: Murphy Zhou <jencce.kernel@gmail.com>
Cc: Linux-Fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: mount(2) with NULL fstype returns ENOENT instead of EINVAL after introducing fs_context methods
Date: Thu, 14 Mar 2019 11:58:32 +0100 [thread overview]
Message-ID: <20190314105832.cv7vtkpja2n47zjh@ws.net.home> (raw)
In-Reply-To: <CADJHv_vW87rgsyOwXNPNWk3KQjJtGUg=kvJQUp3mAQ14v9yamg@mail.gmail.com>
On Thu, Mar 14, 2019 at 03:20:05PM +0800, Murphy Zhou wrote:
> Hi,
>
> Since this
> commit f3a09c92018a91ad0981146a4ac59414f814d801 Author: Al Viro
> <viro@zeniv.linux.org.uk>
> Date: Sun Dec 23 18:55:56 2018 -0500
>
> introduce fs_context methods
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
>
> LTP[1] mount02 tests #5 starts to fail.
>
> This testcase is calling mount(2) with a NULL fs type. It's expecting
> EINVAL to PASS but now we are getting ENOENT.
>
> Should I fix the testcase or there is some work in the kernel ? I'm
> wring this email to confirm with you guys.
It's necessary to fix kernel, because userspace error messages are
generated by error codes.
EINVAL means message "wrong fs type, bad option, bad..."
ENOENT means message "mount(2) system call failed: %m"
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2019-03-14 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 7:20 mount(2) with NULL fstype returns ENOENT instead of EINVAL after introducing fs_context methods Murphy Zhou
2019-03-14 10:58 ` Karel Zak [this message]
2019-03-18 4:56 ` Murphy Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314105832.cv7vtkpja2n47zjh@ws.net.home \
--to=kzak@redhat.com \
--cc=jencce.kernel@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).