archive mirror
 help / color / mirror / Atom feed
* [PATCH] quota: fix a problem about transfer quota
@ 2019-03-21 12:45 yangerkun
  0 siblings, 0 replies; only message in thread
From: yangerkun @ 2019-03-21 12:45 UTC (permalink / raw)
  To: jack; +Cc: yi.zhang, houtao1, miaoxie, linux-fsdevel

Run script as below with root(has the CAP_SYS_RESOUCE), we will trigger
a problem with "Disk quota exceeded". The resons is that after 7b9ca4c61,
__dquot_transfer will call dquot_add_space with flags=0, dquot_add_space
thinks it's a preallocation, then return -EDQUOT. Fix it by set flags as

mkfs.ext4 -O quota,project /dev/vdb
mount -o prjquota /dev/vdb /mnt
setquota -P 23 1 1 0 0 /dev/vdb
dd if=/dev/zero of=/mnt/test-file bs=4K count=1
chattr -p 23 test-file

Fixes: 7b9ca4c61("quota: Reduce contention on dq_data_lock")
Signed-off-by: yangerkun <>
 fs/quota/dquot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index fc20e06..771e99a 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -1993,8 +1993,8 @@ int __dquot_transfer(struct inode *inode, struct dquot **transfer_to)
 		if (ret)
 			goto over_quota;
-		ret = dquot_add_space(transfer_to[cnt], cur_space, rsv_space, 0,
-				      &warn_to[cnt]);
+		ret = dquot_add_space(transfer_to[cnt], cur_space, rsv_space,
+				DQUOT_SPACE_WARN, &warn_to[cnt]);
 		if (ret) {
 			dquot_decr_inodes(transfer_to[cnt], inode_usage);

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-03-21 12:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 12:45 [PATCH] quota: fix a problem about transfer quota yangerkun

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).