Re: [patch] fanotify.7, fanotify_init.2, fanotify_mark.2: Document FAN_REPORT_FID and directory modification events

[Matthew Bobrowski <mbobrowski@mbobrowski.org>]

On Fri, Mar 29, 2019 at 10:37:30PM +0100, Jan Kara wrote:
> On Mon 25-03-19 11:51:39, Matthew Bobrowski wrote:
> > Details relating to the new initialization flag FAN_REPORT_FID has been
> > added. As part of the FAN_REPORT_FID feature, a new set of event masks are
> > available and have been documented accordingly.
> > 
> > A simple example program has been added to also support the understanding
> > and use case of FAN_REPORT_FID.
> > 
> > Signed-off-by: Matthew Bobrowski <mbobrowski@mbobrowski.org>
> > Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> 
> Looks good to me, you can add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>
> 
> Two nits below:

Thanks for the review Jan! Both nits have been addressed so I'll be sending
through version 2 of this patch through at some point today.
 
> > +.I hdr
> > +This is a structure of type
> > +.IR fanotify_event_info_header .
> > +It is a generic header that contains information used to describe
> > +additional information attached to the event.
> > +For example, when an fanotify file descriptor is created using
> > +.B FAN_REPORT_FID
> > +the
> > +.I info_type
> > +field of this header is set to
> > +.BR FAN_EVENT_INFO_TYPE_FID .
> > +Event listeners can use this field to check that events of the correct
>                                                     ^^^ additional
> information of the correct type?
> 
> ...

I've changed it to the following which I believe is more accurate and is
aligned with your recommendation.

--
Event listeners can use this field to check that the additional
information received for an event is of the correct type.
--

-- 
Matthew Bobrowski