From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA6C1C43381 for ; Mon, 1 Apr 2019 17:45:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3F8520830 for ; Mon, 1 Apr 2019 17:45:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387952AbfDARoy (ORCPT ); Mon, 1 Apr 2019 13:44:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53130 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730920AbfDARox (ORCPT ); Mon, 1 Apr 2019 13:44:53 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 92EFA81224; Mon, 1 Apr 2019 17:44:52 +0000 (UTC) Received: from madcap2.tricolour.ca (ovpn-112-19.phx2.redhat.com [10.3.112.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 62C995C21F; Mon, 1 Apr 2019 17:44:35 +0000 (UTC) Date: Mon, 1 Apr 2019 13:44:32 -0400 From: Richard Guy Briggs To: Paul Moore Cc: containers@lists.linux-foundation.org, linux-api@vger.kernel.org, Linux-Audit Mailing List , linux-fsdevel@vger.kernel.org, LKML , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, sgrubb@redhat.com, omosnace@redhat.com, dhowells@redhat.com, simo@redhat.com, Eric Paris , Serge Hallyn , ebiederm@xmission.com, nhorman@tuxdriver.com Subject: Re: [PATCH ghak90 V5 06/10] audit: add support for non-syscall auxiliary records Message-ID: <20190401174432.fjnvotpvdrfujoy7@madcap2.tricolour.ca> References: <700e4313571f86cc0cdcb7310fbe060f02c7c2db.1552665316.git.rgb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 01 Apr 2019 17:44:52 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2019-04-01 10:49, Paul Moore wrote: > On Fri, Mar 15, 2019 at 2:34 PM Richard Guy Briggs wrote: > > Standalone audit records have the timestamp and serial number generated > > on the fly and as such are unique, making them standalone. This new > > function audit_alloc_local() generates a local audit context that will > > be used only for a standalone record and its auxiliary record(s). The > > context is discarded immediately after the local associated records are > > produced. > > > > Signed-off-by: Richard Guy Briggs > > Acked-by: Serge Hallyn > > --- > > include/linux/audit.h | 8 ++++++++ > > kernel/audit.h | 1 + > > kernel/auditsc.c | 35 ++++++++++++++++++++++++++++++----- > > 3 files changed, 39 insertions(+), 5 deletions(-) > > ... > > > diff --git a/include/linux/audit.h b/include/linux/audit.h > > index ebd6625ca80e..6db5aba7cc01 100644 > > --- a/include/linux/audit.h > > +++ b/include/linux/audit.h > > @@ -285,6 +285,8 @@ static inline void audit_log_contid(struct audit_context *context, u64 contid) > > > > /* These are defined in auditsc.c */ > > /* Public API */ > > +extern struct audit_context *audit_alloc_local(gfp_t gfpflags); > > +extern void audit_free_context(struct audit_context *context); > > extern void __audit_syscall_entry(int major, unsigned long a0, unsigned long a1, > > unsigned long a2, unsigned long a3); > > extern void __audit_syscall_exit(int ret_success, long ret_value); > > @@ -512,6 +514,12 @@ static inline void audit_fanotify(unsigned int response) > > extern int audit_n_rules; > > extern int audit_signals; > > #else /* CONFIG_AUDITSYSCALL */ > > +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags) > > +{ > > + return NULL; > > +} > > +static inline void audit_free_context(struct audit_context *context) > > +{ } > > static inline void audit_syscall_entry(int major, unsigned long a0, > > unsigned long a1, unsigned long a2, > > unsigned long a3) > > diff --git a/kernel/audit.h b/kernel/audit.h > > index c5ac6436317e..2a1a8b8a8019 100644 > > --- a/kernel/audit.h > > +++ b/kernel/audit.h > > @@ -111,6 +111,7 @@ struct audit_proctitle { > > struct audit_context { > > int dummy; /* must be the first element */ > > int in_syscall; /* 1 if task is in a syscall */ > > + bool local; /* local context needed */ > > It's very possible I've missed it, but "local" never gets used in any > meaningful way in this patchset does it? It is used in audit_alloc_local() to signal to audit_get_stamp() that in absence of a syscall flag, check for a local flag to continue rather than return. > > enum audit_state state, current_state; > > unsigned int serial; /* serial number for record */ > > int major; /* syscall number */ > > paul moore - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635