From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=BIGNUM_EMAILS,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C6B5C4360F for ; Fri, 5 Apr 2019 04:58:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D03C221852 for ; Fri, 5 Apr 2019 04:58:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="v2yYlsFi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726575AbfDEE6r (ORCPT ); Fri, 5 Apr 2019 00:58:47 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:60788 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbfDEE6r (ORCPT ); Fri, 5 Apr 2019 00:58:47 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x354wcw2070987; Fri, 5 Apr 2019 04:58:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=az9RINJtjsVfEk52Mp7LErsm/oNmxF4yLBt+Oa6+g1A=; b=v2yYlsFiYzhWSFcHT3fWw6fOGB81VT+SKtvJCKepBF6AnprVexlmGoJYuIRUSWE2ZVwI cVF8Br6rK1QnYu3nt7EudOIJWg3JNT4+iMbYZvit8QRHALyQGSFfu11aRvy+itH5O0jd Hr5CEQLCw+U1cF9dpMgT12mmcFOkjNf7wjpP1RdROnkgYUHCySGwEPAKlqyerUyH0SwB e2VDKhhQdy2DJxBVS1MzEF/Zpd011OCixa7GH1RxBt4oCd96blQrI171Bytlq8e4FQPU adWerbM04E1iWMIGPpr0f/yE1kvEfEJw4n0aLsLeHAA0SEucY8UlZRW2kMtKLv6dDzFE dQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2rhyvtjqh1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Apr 2019 04:58:42 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x354vfvD110492; Fri, 5 Apr 2019 04:58:42 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2rm8f724d0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Apr 2019 04:58:42 +0000 Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x354ween004573; Fri, 5 Apr 2019 04:58:41 GMT Received: from kadam (/41.202.241.49) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 04 Apr 2019 21:58:25 -0700 USER-AGENT: Mutt/1.9.4 (2018-02-28) MIME-Version: 1.0 Message-ID: <20190405045752.GR32613@kadam> Date: Thu, 4 Apr 2019 21:57:52 -0700 (PDT) From: Dan Carpenter To: cgxu519 Cc: linux-fsdevel@vger.kernel.org Subject: Re: [bug report] chardev: code cleanup for __register_chrdev_region() References: <20190404190828.GA28465@kadam> In-Reply-To: Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9217 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=680 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904050036 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9217 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=726 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904050037 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Apr 05, 2019 at 07:13:00AM +0800, cgxu519 wrote: > On 4/5/19 3:08 AM, Dan Carpenter wrote: > > Hello Chengguang Xu, > > > > The patch 4b0be5726032: "chardev: code cleanup for > > __register_chrdev_region()" from Feb 15, 2019, leads to the following > > static checker warning: > > > > fs/char_dev.c:167 __register_chrdev_region() > > error: passing non negative 511 to ERR_PTR > > Hi Dan, > > Thanks for your report,  I would like to know how did you trigger this? This a Smatch warning but you probably need to have the cross function DB built to see it. > IIUC, in the case of allocating dynamic major will not fail from minor > overlap check. Fine, but it's harmless to set "ret = -EBUSY;" before the goto out just to silence the warning. It would make the code more easy to understand as well. regards, dan carpenter