From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27A88C282CE for ; Wed, 10 Apr 2019 08:35:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFF782075B for ; Wed, 10 Apr 2019 08:35:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729614AbfDJIfS (ORCPT ); Wed, 10 Apr 2019 04:35:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:54024 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726630AbfDJIfR (ORCPT ); Wed, 10 Apr 2019 04:35:17 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A9B74AE64; Wed, 10 Apr 2019 08:35:15 +0000 (UTC) From: Qu Wenruo To: linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 2/2] block: Add new BLK_STS_FSCORRUPTED status Date: Wed, 10 Apr 2019 16:35:08 +0800 Message-Id: <20190410083508.21091-2-wqu@suse.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190410083508.21091-1-wqu@suse.com> References: <20190410083508.21091-1-wqu@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org There are quite a lot of filesystems doing their verification work done at endio hook or hook before submitting bio. Normally such verification returns -EUCLEAN/-EFSCORRUPTED to indicate something unexpected, and some of such verification either use bio->bi_status or users bio->bi_endio to return their value. In such case, the missing of corresponding BLK_STS_ bit can lower the severity just like: In endio function: return errno_to_blk_status(-EFSCORRUPTED); ^^^ -EFSCORRUPTED gets interpreted to BLK_STS_IOERR In the filesystem code: ret = blk_status_to_errno(bi->bi_status); ^^^ BLK_STS_IOERR gets interpreted to -EIO; This lowers the severity, making the filesystem layer to believe it's just an ordinary error. This patch will add a new BLK_STS_FSCORRUPTED, to allow -EFSCORRUPTED to be converted to BLK_STS_FSCORRUPTED, and then converted back to -EFSCORRUPTED without losing info. Signed-off-by: Qu Wenruo --- block/blk-core.c | 1 + include/linux/blk_types.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/block/blk-core.c b/block/blk-core.c index a55389ba8779..ba7acfc3d8e0 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -135,6 +135,7 @@ static const struct { [BLK_STS_RESOURCE] = { -ENOMEM, "kernel resource" }, [BLK_STS_DEV_RESOURCE] = { -EBUSY, "device resource" }, [BLK_STS_AGAIN] = { -EAGAIN, "nonblocking retry" }, + [BLK_STS_FSCORRUPTED] = { -EFSCORRUPTED, "filesystem is corrupted" }, /* device mapper special case, should not leak out: */ [BLK_STS_DM_REQUEUE] = { -EREMCHG, "dm internal retry" }, diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index 791fee35df88..8f70bbec6c83 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -63,6 +63,9 @@ typedef u8 __bitwise blk_status_t; */ #define BLK_STS_DEV_RESOURCE ((__force blk_status_t)13) +/* Normally filesystem layer generated error */ +#define BLK_STS_FSCORRUPTED ((__force blk_status_t)14) + /** * blk_path_error - returns true if error may be path related * @error: status the request was completed with -- 2.21.0