From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E71F0C10F14 for ; Thu, 11 Apr 2019 17:28:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB6B52146F for ; Thu, 11 Apr 2019 17:28:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555003730; bh=Z0/DmaNrnDC9OrljK1poyZTLwzQJq8FwEv9dGTtd81Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=W3Yyg7PZdQUirEjrSLRLmcxdR8FZDSU+IATJ9ebMilUzd0PPDN6MZ+l0aar4dx565 XeD/j/0C4iMw/HVDZniA8CBhAKHgGC/6HSvlRb9FWYOCsMdKMh5tQtrb9opT4HporW 1XD+idUn8Hc0WvFqaZPrkRe/dztX1SPfdaLGk5hQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbfDKR2s (ORCPT ); Thu, 11 Apr 2019 13:28:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:40404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726585AbfDKR2s (ORCPT ); Thu, 11 Apr 2019 13:28:48 -0400 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 08C462084D; Thu, 11 Apr 2019 17:28:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555003727; bh=Z0/DmaNrnDC9OrljK1poyZTLwzQJq8FwEv9dGTtd81Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rUL2CvSaEyQQ2WRpMdkdT2D3P6oXuBAQymfy8FzOSYy4nTmeel9KPNRTM/uBXT6Pa mAdwIJKBw9vOpFZKrCZd5pEgrYP0ta6vZbmgICqodIuasVHUWpf2BUo9hW+PH5zgZH r0XyIAKdCd250xyT9oprWqE3nQsgIGpkd1lw2VgQ= Date: Thu, 11 Apr 2019 10:28:45 -0700 From: Eric Biggers To: Al Viro Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org Subject: Re: [PATCH v2 1/2] vfs: use READ_ONCE() to access ->i_link Message-ID: <20190411172844.GA225654@gmail.com> References: <20190410202115.64501-1-ebiggers@kernel.org> <20190410202115.64501-2-ebiggers@kernel.org> <20190410210657.GA2217@ZenIV.linux.org.uk> <20190410231547.GC120258@gmail.com> <20190411022514.GC2217@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190411022514.GC2217@ZenIV.linux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Apr 11, 2019 at 03:25:15AM +0100, Al Viro wrote: > On Wed, Apr 10, 2019 at 04:15:48PM -0700, Eric Biggers wrote: > > On Wed, Apr 10, 2019 at 10:06:57PM +0100, Al Viro wrote: > > > On Wed, Apr 10, 2019 at 01:21:14PM -0700, Eric Biggers wrote: > > > > From: Eric Biggers > > > > > > > > Use 'READ_ONCE(inode->i_link)' to explicitly support filesystems caching > > > > the symlink target in ->i_link later if it was unavailable at iget() > > > > time, or wasn't easily available. I'll be doing this in fscrypt, to > > > > improve the performance of encrypted symlinks on ext4, f2fs, and ubifs. > > > > > > > > ->i_link will start NULL and may later be set to a non-NULL value by a > > > > smp_store_release() or cmpxchg_release(). READ_ONCE() is needed on the > > > > read side. smp_load_acquire() is unnecessary because only a data > > > > dependency barrier is required. (Thanks to Al for pointing this out.) > > > > > > You've missed vfs_readlink()... > > > > How so? The patch already updates vfs_readlink(). > > Huh? Right you are - fsck knows how have I managed to misread that... > Anyway, I can pick that READ_ONCE() patch through vfs.git if you wish, > or it can go through your tree with my Acked-by - up to you... Unless you expect merge conflicts, it's easier for me to take it through the fscrypt tree, since it's a small patch and the second patch technically isn't correct without it. I'll add your Acked-by. Are you planning to review the second patch too? Thanks! - Eric