From: Peter Zijlstra <peterz@infradead.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
tj@kernel.org
Subject: Re: misuse of fget_raw() in perf_event_get()
Date: Mon, 15 Apr 2019 11:04:06 +0200 [thread overview]
Message-ID: <20190415090406.GJ2490@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20190415044158.5goa2je57j63kwaz@ast-mbp.dhcp.thefacebook.com>
On Sun, Apr 14, 2019 at 09:42:00PM -0700, Alexei Starovoitov wrote:
> On Sat, Apr 13, 2019 at 10:02:42PM +0100, Al Viro wrote:
> > What's the point of using fget_raw(), if you do
> > _not_ accept O_PATH descriptors? That should be fget()...
>
> I think you're talking about commit e03e7ee34fdd ("perf/bpf: Convert perf_event_array to use struct file")
> I don't really remember why we went with this instead of fget().
> There was a bunch of back and forth back then with Peter.
That was mostly on what refcount to use, you wanted to use the event
refcount, and I suggested using the file refcount.
If you look at:
lkml.kernel.org/r/20160126161637.GF6357@twins.programming.kicks-ass.net
I too wondered about the fget_raw() at the time, whatever Al wants
though, I never quite remember how that file stuff works :/
next prev parent reply other threads:[~2019-04-15 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 21:02 misuse of fget_raw() in perf_event_get() Al Viro
2019-04-15 4:42 ` Alexei Starovoitov
2019-04-15 9:04 ` Peter Zijlstra [this message]
2019-06-27 0:56 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415090406.GJ2490@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alexei.starovoitov@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).