From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAE53C282DA for ; Wed, 17 Apr 2019 13:53:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A62F620872 for ; Wed, 17 Apr 2019 13:53:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732240AbfDQNxo (ORCPT ); Wed, 17 Apr 2019 09:53:44 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:38850 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729453AbfDQNxo (ORCPT ); Wed, 17 Apr 2019 09:53:44 -0400 Received: from callcc.thunk.org (guestnat-104-133-0-109.corp.google.com [104.133.0.109] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x3HDrKZi023379 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Apr 2019 09:53:21 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id DB208420497; Wed, 17 Apr 2019 09:53:19 -0400 (EDT) Date: Wed, 17 Apr 2019 09:53:19 -0400 From: "Theodore Ts'o" To: Eric Biggers Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, linux-unionfs@vger.kernel.org, Sarthak Kukreti , Gao Xiang Subject: Re: [PATCH v2 2/5] fscrypt: fix race allowing rename() and link() of ciphertext dentries Message-ID: <20190417135319.GB4686@mit.edu> References: <20190320183913.12686-1-ebiggers@kernel.org> <20190320183913.12686-3-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190320183913.12686-3-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Mar 20, 2019 at 11:39:10AM -0700, Eric Biggers wrote: > From: Eric Biggers > > Close some race conditions where fscrypt allowed rename() and link() on > ciphertext dentries that had been looked up just prior to the key being > concurrently added. It's better to return -ENOKEY in this case. > > This avoids doing the nonsensical thing of encrypting the names a second > time when searching for the actual on-disk dir entries. It also > guarantees that DCACHE_ENCRYPTED_NAME dentries are never rename()d, so > the dcache won't have support all possible combinations of moving > DCACHE_ENCRYPTED_NAME around during __d_move(). > > Signed-off-by: Eric Biggers Looks good, applied. - Ted