From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B493BC10F0E for ; Thu, 18 Apr 2019 10:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E64421479 for ; Thu, 18 Apr 2019 10:04:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388314AbfDRKEO (ORCPT ); Thu, 18 Apr 2019 06:04:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37772 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728074AbfDRKEO (ORCPT ); Thu, 18 Apr 2019 06:04:14 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A63CE308A10F; Thu, 18 Apr 2019 10:04:14 +0000 (UTC) Received: from shalem.localdomain.com (ovpn-117-101.ams2.redhat.com [10.36.117.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id B49FB19C79; Thu, 18 Apr 2019 10:04:13 +0000 (UTC) From: Hans de Goede To: Alexander Viro Cc: Hans de Goede , David Howells , linux-fsdevel@vger.kernel.org Subject: [PATCH v10 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support Date: Thu, 18 Apr 2019 12:04:11 +0200 Message-Id: <20190418100412.19016-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 18 Apr 2019 10:04:14 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hello Everyone, Here is the 10th version of my cleaned-up / refactored version of the VirtualBox shared-folder VFS driver. This version hopefully addresses all issues pointed out in Al's detailed review of v9 (thank you for the review Al): Changes in v10: -Code-style fixes and remove some unneeded checks as suggested by Al Viro -Stop handle reuse between sf_create_aux and sf_reg_open, the code for this was racy and the re-use meant the O_APPEND was not passed to the host for newly created files with O_APPEND set -Use idr to generate unique inode number, modelled after the kernfs code -Only read and write the contents of the passed in offset pointer once in sf_reg_write -Keep a list of refcounted open handles in the inode, so that writepage can get a writeable handle this way. This replaces the old very racy code which was just storing a pointer to the last opened struct file inside the inode. This is modelled after how the cifs and fuse code do this For changes in older versions see the change log in the patch. This version has been used by several distributions (arch, Fedora) for a while now, so hopefully we can get this upstream soonish, please review. Regards, Hans