From: kbuild test robot <lkp@intel.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: kbuild-all@01.org, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V2] block: clarify that bio_add_page() and related helpers can add multi pages
Date: Tue, 23 Apr 2019 02:30:58 +0800 [thread overview]
Message-ID: <201904230205.g533Pqs6%lkp@intel.com> (raw)
In-Reply-To: <20190422100207.13057-1-ming.lei@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 3163 bytes --]
Hi Ming,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on block/for-next]
[also build test ERROR on next-20190418]
[cannot apply to v5.1-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Ming-Lei/block-clarify-that-bio_add_page-and-related-helpers-can-add-multi-pages/20190423-010505
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: x86_64-randconfig-x015-201916 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from arch/x86/include/asm/bug.h:83:0,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/mm.h:9,
from block/bio.c:18:
block/bio.c: In function 'can_add_page_to_seg':
>> block/bio.c:691:15: error: 'same_page' undeclared (first use in this function); did you mean 'shake_page'?
WARN_ON_ONCE(same_page && (len + off) > PAGE_SIZE);
^
include/asm-generic/bug.h:69:25: note: in definition of macro 'WARN_ON_ONCE'
int __ret_warn_on = !!(condition); \
^~~~~~~~~
block/bio.c:691:15: note: each undeclared identifier is reported only once for each function it appears in
WARN_ON_ONCE(same_page && (len + off) > PAGE_SIZE);
^
include/asm-generic/bug.h:69:25: note: in definition of macro 'WARN_ON_ONCE'
int __ret_warn_on = !!(condition); \
^~~~~~~~~
>> block/bio.c:691:35: error: 'off' undeclared (first use in this function)
WARN_ON_ONCE(same_page && (len + off) > PAGE_SIZE);
^
include/asm-generic/bug.h:69:25: note: in definition of macro 'WARN_ON_ONCE'
int __ret_warn_on = !!(condition); \
^~~~~~~~~
vim +691 block/bio.c
672
673 /*
674 * Check if the @page can be added to the current segment(@bv), and make
675 * sure to call it only if page_is_mergeable(@bv, @page) is true
676 */
677 static bool can_add_page_to_seg(struct request_queue *q,
678 struct bio_vec *bv, struct page *page, unsigned len,
679 unsigned offset)
680 {
681 unsigned long mask = queue_segment_boundary(q);
682 phys_addr_t addr1 = page_to_phys(bv->bv_page) + bv->bv_offset;
683 phys_addr_t addr2 = page_to_phys(page) + offset + len - 1;
684
685 if ((addr1 | mask) != (addr2 | mask))
686 return false;
687
688 if (bv->bv_len + len > queue_max_segment_size(q))
689 return false;
690
> 691 WARN_ON_ONCE(same_page && (len + off) > PAGE_SIZE);
692
693 return true;
694 }
695
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30526 bytes --]
next prev parent reply other threads:[~2019-04-22 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 10:02 [PATCH V2] block: clarify that bio_add_page() and related helpers can add multi pages Ming Lei
2019-04-22 18:30 ` kbuild test robot [this message]
2019-04-23 6:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201904230205.g533Pqs6%lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=kbuild-all@01.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).