From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel@redhat.com, Christoph Hellwig <hch@lst.de>
Cc: "Bob Peterson" <rpeterso@redhat.com>, "Jan Kara" <jack@suse.cz>,
"Dave Chinner" <david@fromorbit.com>,
"Ross Lagerwall" <ross.lagerwall@citrix.com>,
"Mark Syms" <Mark.Syms@citrix.com>,
"Edwin Török" <edvin.torok@citrix.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
"Andreas Gruenbacher" <agruenba@redhat.com>
Subject: [PATCH 1/2] iomap: Add a page_prepare callback
Date: Wed, 24 Apr 2019 19:18:03 +0200 [thread overview]
Message-ID: <20190424171804.4305-1-agruenba@redhat.com> (raw)
Add a page_prepare calback that's called before a page is written to. This
will be used by gfs2 to start a transaction in page_prepare and end it in
page_done. Other filesystems that implement data journaling will require the
same kind of mechanism.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
fs/iomap.c | 4 ++++
include/linux/iomap.h | 9 ++++++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/fs/iomap.c b/fs/iomap.c
index 97cb9d486a7d..abd9aa76dbd1 100644
--- a/fs/iomap.c
+++ b/fs/iomap.c
@@ -684,6 +684,10 @@ iomap_write_begin(struct inode *inode, loff_t pos, unsigned len, unsigned flags,
status = __block_write_begin_int(page, pos, len, NULL, iomap);
else
status = __iomap_write_begin(inode, pos, len, page, iomap);
+
+ if (likely(!status) && iomap->page_prepare)
+ status = iomap->page_prepare(inode, pos, len, page, iomap);
+
if (unlikely(status)) {
unlock_page(page);
put_page(page);
diff --git a/include/linux/iomap.h b/include/linux/iomap.h
index 0fefb5455bda..0982f3e13e56 100644
--- a/include/linux/iomap.h
+++ b/include/linux/iomap.h
@@ -65,10 +65,13 @@ struct iomap {
void *private; /* filesystem private */
/*
- * Called when finished processing a page in the mapping returned in
- * this iomap. At least for now this is only supported in the buffered
- * write path.
+ * Called before / after processing a page in the mapping returned in
+ * this iomap. At least for now, this is only supported in the
+ * buffered write path. When page_prepare returns 0 for a page,
+ * page_done is called for that page as well.
*/
+ int (*page_prepare)(struct inode *inode, loff_t pos, unsigned len,
+ struct page *page, struct iomap *iomap);
void (*page_done)(struct inode *inode, loff_t pos, unsigned copied,
struct page *page, struct iomap *iomap);
};
--
2.20.1
next reply other threads:[~2019-04-24 18:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 17:18 Andreas Gruenbacher [this message]
2019-04-24 17:18 ` [PATCH 2/2] gfs2: Fix iomap write page reclaim deadlock Andreas Gruenbacher
2019-04-25 7:59 ` [PATCH 1/2] iomap: Add a page_prepare callback Christoph Hellwig
2019-04-25 8:32 ` Jan Kara
2019-04-25 15:03 ` Christoph Hellwig
2019-04-25 15:26 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424171804.4305-1-agruenba@redhat.com \
--to=agruenba@redhat.com \
--cc=Mark.Syms@citrix.com \
--cc=cluster-devel@redhat.com \
--cc=david@fromorbit.com \
--cc=edvin.torok@citrix.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ross.lagerwall@citrix.com \
--cc=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).